fix(server/stdio): risk of concurrent reads and data loss in readNextLine() (#257)

cryo-zd · web-flow · commit 3dfa33164fe6 · 2025-05-10T20:54:39.000+03:00
diff --git a/server/stdio.go b/server/stdio.go
@@ -171,14 +171,14 @@ func (s *StdioServer) readNextLine(ctx context.Context, reader *bufio.Reader) (s
 				select {
 				case errChan <- err:
 				case <-done:
-
 				}
 				return
 			}
 			select {
 			case readChan <- line:
 			case <-done:
 			}
+			return
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -171,14 +171,14 @@ func (s StdioServer) readNextLine(ctx context.Context, reader bufio.Reader) (s`
`171`	`171`	`select {`
`172`	`172`	`case errChan <- err:`
`173`	`173`	`case <-done:`
`174`		`-`
`175`	`174`	`}`
`176`	`175`	`return`
`177`	`176`	`}`
`178`	`177`	`select {`
`179`	`178`	`case readChan <- line:`
`180`	`179`	`case <-done:`
`181`	`180`	`}`
	`181`	`+ return`
`182`	`182`	`}`
`183`	`183`	`}()`
`184`	`184`