Skip to content

Commit 7fd433b

Browse files
authored
Rename f8E4M3 to f8E4M3FN in mlir.extras.types py package (#97102)
Currently `f8E4M3` is mapped to `Float8E4M3FNType`. This PR renames `f8E4M3` to `f8E4M3FN` to accurately reflect the actual type. This PR is needed to avoid names conflict in upcoming PR which will add IEEE 754 `Float8E4M3Type`. llvm/llvm-project#97118 Add f8E4M3 IEEE 754 type Maksim, can you review this PR? makslevental ?
1 parent d355914 commit 7fd433b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mlir/python/mlir/extras/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def ui(width):
6868
bf16 = lambda: BF16Type.get()
6969

7070
f8E5M2 = lambda: Float8E5M2Type.get()
71-
f8E4M3 = lambda: Float8E4M3FNType.get()
71+
f8E4M3FN = lambda: Float8E4M3FNType.get()
7272
f8E4M3B11FNUZ = lambda: Float8E4M3B11FNUZType.get()
7373

7474
none = lambda: NoneType.get()

0 commit comments

Comments
 (0)