diff --git a/app/code/Magento/Reports/Model/ResourceModel/Customer/Totals/Collection/Initial.php b/app/code/Magento/Reports/Model/ResourceModel/Customer/Totals/Collection/Initial.php index 66bbc01aead76..4bf9a861f3ab8 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Customer/Totals/Collection/Initial.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Customer/Totals/Collection/Initial.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Customer\Totals\Collection; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Event/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Event/Collection.php index f2a9e3e5ca1b1..02e24c475a55d 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Event/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Event/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Event; @@ -18,8 +16,6 @@ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection { /** - * Store Ids - * * @var array */ protected $_storeIds; @@ -36,8 +32,8 @@ protected function _construct() /** * Add store ids filter - * @codeCoverageIgnore * + * @codeCoverageIgnore * @param array $storeIds * @return $this */ diff --git a/app/code/Magento/Reports/Model/ResourceModel/Event/Type.php b/app/code/Magento/Reports/Model/ResourceModel/Event/Type.php index fead319b46fa5..140a12a947c5a 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Event/Type.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Event/Type.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Event; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Event/Type/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Event/Type/Collection.php index 9264fd6dc46d0..2d965a6179f4a 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Event/Type/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Event/Type/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Event\Type; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Helper.php b/app/code/Magento/Reports/Model/ResourceModel/Helper.php index 9096d3416ee53..9363e0e4e9f6c 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Helper.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Helper.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Downloads/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Downloads/Collection.php index ed3e4e8c4446d..95425d9e2ae95 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Downloads/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Downloads/Collection.php @@ -1,7 +1,7 @@ - * * @api * @since 100.0.2 * @SuppressWarnings(PHPMD.CookieAndSessionMisuse) diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php index f4b92dac090ee..3b433e361c8f0 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Collection/AbstractCollection.php @@ -1,12 +1,9 @@ - */ namespace Magento\Reports\Model\ResourceModel\Product\Index\Collection; /** @@ -21,8 +18,6 @@ abstract class AbstractCollection extends \Magento\Catalog\Model\ResourceModel\Product\Collection { /** - * Customer id - * * @var null|int */ protected $_customerId = null; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared.php index 1b91573031f03..00b40ce76ffc1 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Index; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection.php index e03bad30a15e8..22eaf0fb0757e 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Compared/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Index\Compared; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed.php index 718ddde0fe2e9..9cff26af5e6bc 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Index; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection.php index 9262ac990b994..2f79a2697a26b 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Index/Viewed/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Index\Viewed; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Lowstock/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Lowstock/Collection.php index e3ff78df68823..d561a33683cc6 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Lowstock/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Lowstock/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Lowstock; @@ -229,6 +227,7 @@ public function joinInventoryItem($fields = []) } if (!is_array($fields)) { + // phpstan:ignore if (empty($fields)) { $fields = []; } else { diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection.php index bc8a67c2addff..295da003d662a 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Sold; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection/Initial.php b/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection/Initial.php index 88b499a4eff98..adc47504af43b 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection/Initial.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Product/Sold/Collection/Initial.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Product\Sold\Collection; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Refresh/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Refresh/Collection.php index ef79ad0d73f21..fb71985c4f30f 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Refresh/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Refresh/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Refresh; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Report/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Report/Collection.php index 26b63ce2cb631..8d51336f03094 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Report/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Report/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Report; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Report/Product/Viewed.php b/app/code/Magento/Reports/Model/ResourceModel/Report/Product/Viewed.php index 18afcf3f009f5..ae7af6cf21138 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Report/Product/Viewed.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Report/Product/Viewed.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Report\Product; @@ -20,17 +18,17 @@ class Viewed extends \Magento\Sales\Model\ResourceModel\Report\AbstractReport /** * Aggregation key daily */ - const AGGREGATION_DAILY = 'report_viewed_product_aggregated_daily'; + public const AGGREGATION_DAILY = 'report_viewed_product_aggregated_daily'; /** * Aggregation key monthly */ - const AGGREGATION_MONTHLY = 'report_viewed_product_aggregated_monthly'; + public const AGGREGATION_MONTHLY = 'report_viewed_product_aggregated_monthly'; /** * Aggregation key yearly */ - const AGGREGATION_YEARLY = 'report_viewed_product_aggregated_yearly'; + public const AGGREGATION_YEARLY = 'report_viewed_product_aggregated_yearly'; /** * Product resource instance diff --git a/app/code/Magento/Reports/Model/ResourceModel/Review/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Review/Collection.php index 7a7f72cbfb648..8a2c662bc4a6a 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Review/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Review/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Review; @@ -47,7 +45,9 @@ public function addProductFilter($productId) */ public function resetSelect() { + // phpstan:ignore "Call to an undefined static method" parent::resetSelect(); + // phpstan:ignore $this->_joinFields(); return $this; } diff --git a/app/code/Magento/Reports/Model/ResourceModel/Review/Customer/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Review/Customer/Collection.php index 94ac4f3e46ee7..7ce17fc98264c 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Review/Customer/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Review/Customer/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Review\Customer; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Review/Product/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Review/Product/Collection.php index 69221af3322f0..c34d2d70f98e6 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Review/Product/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Review/Product/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Review\Product; diff --git a/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Collection.php index aa83a48216e73..a0c9b3921c398 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Wishlist; @@ -64,8 +62,8 @@ protected function _construct() /** * Set wishlist table name - * @codeCoverageIgnore * + * @codeCoverageIgnore * @param string $value * @return $this */ @@ -77,8 +75,8 @@ public function setWishlistTable($value) /** * Retrieve wishlist table name - * @codeCoverageIgnore * + * @codeCoverageIgnore * @return string */ public function getWishlistTable() diff --git a/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Product/Collection.php b/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Product/Collection.php index a74cc5fb35821..22825e775dfb4 100644 --- a/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Product/Collection.php +++ b/app/code/Magento/Reports/Model/ResourceModel/Wishlist/Product/Collection.php @@ -1,13 +1,11 @@ */ namespace Magento\Reports\Model\ResourceModel\Wishlist\Product; @@ -44,7 +42,7 @@ public function addWishlistCount() )->group( 'wi.product_id' ); - + // phpstan:ignore $this->getEntity()->setStore(0); return $this; } diff --git a/app/code/Magento/Sales/Block/Adminhtml/Creditmemo.php b/app/code/Magento/Sales/Block/Adminhtml/Creditmemo.php index 4636a8c2cb087..3b7b33affc6e7 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Creditmemo.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Creditmemo.php @@ -1,18 +1,18 @@ */ class Creditmemo extends \Magento\Backend\Block\Widget\Grid\Container { /** + * Initialize + * * @return void */ protected function _construct() diff --git a/app/code/Magento/Sales/Block/Adminhtml/Invoice.php b/app/code/Magento/Sales/Block/Adminhtml/Invoice.php index 0a6207299f463..3002e7eb61a7d 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Invoice.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Invoice.php @@ -1,14 +1,12 @@ */ class Invoice extends \Magento\Backend\Block\Widget\Grid\Container { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Items/Column/Qty.php b/app/code/Magento/Sales/Block/Adminhtml/Items/Column/Qty.php index 0889b7dcaa74e..3867300c5e9af 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Items/Column/Qty.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Items/Column/Qty.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Qty extends \Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order.php b/app/code/Magento/Sales/Block/Adminhtml/Order.php index 614130af74f04..b3fda1f450cc5 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order.php @@ -1,14 +1,12 @@ */ class Order extends \Magento\Backend\Block\Widget\Grid\Container { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/AbstractOrder.php b/app/code/Magento/Sales/Block/Adminhtml/Order/AbstractOrder.php index aa9266e1d2d9c..6d1e71f3fb243 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/AbstractOrder.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/AbstractOrder.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class AbstractOrder extends \Magento\Backend\Block\Widget diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Comments/View.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Comments/View.php index 1b3e5a212e64c..68ba7c51bba6b 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Comments/View.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Comments/View.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class View extends \Magento\Backend\Block\Template { /** - * Sales data - * * @var \Magento\Sales\Helper\Data */ protected $_salesData = null; @@ -86,6 +83,8 @@ public function getSubmitUrl() } /** + * Can send comment email + * * @return bool */ public function canSendCommentEmail() diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create.php index 083055994a282..3c9eccd450bd7 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Create extends \Magento\Backend\Block\Widget\Form\Container { /** - * Session quote - * * @var \Magento\Backend\Model\Session\Quote */ protected $_sessionQuote; @@ -86,7 +83,7 @@ protected function _construct() } /** - * {@inheritdoc} + * @inheritdoc * * @return $this */ diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php index f335705e3deee..d24357f53b817 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/AbstractCreate.php @@ -1,7 +1,7 @@ * @SuppressWarnings(PHPMD.NumberOfChildren) */ abstract class AbstractCreate extends \Magento\Backend\Block\Widget { /** - * Session quote - * * @var \Magento\Backend\Model\Session\Quote */ protected $_sessionQuote; /** - * Order create - * * @var \Magento\Sales\Model\AdminOrder\Create */ protected $_orderCreate; @@ -133,6 +128,8 @@ public function formatPrice($value) } /** + * Get Item Price + * * @param Product $product * @return string */ @@ -164,6 +161,7 @@ public function convertPrice($value, $format = true) /** * If item is quote or wishlist we need to get product from it. * + * phpcs:disable * @param $item * * @return Product diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php index fff10f672603a..47277e2a21817 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Address.php @@ -1,7 +1,7 @@ * @SuppressWarnings(PHPMD.DepthOfInheritance) * @since 100.0.2 */ diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method.php index f14db61ebc9ee..8b2f3716c4e25 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Method extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method/Form.php index 3acb3fcacd809..32b5340a1a07d 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Billing/Method/Form.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Form extends \Magento\Payment\Block\Form\Container { /** - * Session quote - * * @var \Magento\Backend\Model\Session\Quote */ protected $_sessionQuote; @@ -106,6 +103,7 @@ public function getQuote() * * @return true * @deprecated 100.1.0 unused + * @see nothing */ public function hasSsCardType() { diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Comment.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Comment.php index 9a8bac6ea8f80..c5f7fa02bcf1f 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Comment.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Comment.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Comment extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons.php index a8ead4a2599eb..1589ef9d625bb 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Coupons extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate diff --git a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons/Form.php b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons/Form.php index 9e253cf7dedb2..d7cb46878dbc2 100644 --- a/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons/Form.php +++ b/app/code/Magento/Sales/Block/Adminhtml/Order/Create/Coupons/Form.php @@ -1,7 +1,7 @@ * @since 100.0.2 */ class Form extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate