Skip to content

Commit f78e59c

Browse files
committed
Merge remote-tracking branch 'git-36978/no-author/framework-02' into bluetooth_delivery
2 parents 3ef65e4 + c1549d1 commit f78e59c

22 files changed

+42
-52
lines changed

lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
*
1919
* phpcs:disable Magento2.Classes.AbstractApi
2020
* @api
21-
* @author Magento Core Team <[email protected]>
2221
* @SuppressWarnings(PHPMD.NumberOfChildren)
2322
* @since 100.0.2
2423
*/

lib/internal/Magento/Framework/Data/Form/Element/Button.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form button element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
7+
68
namespace Magento\Framework\Data\Form\Element;
79

810
use Magento\Framework\Escaper;
911

1012
/**
1113
* Form checkbox element
12-
*
13-
* @author Magento Core Team <[email protected]>
1414
*/
1515
class Checkbox extends AbstractElement
1616
{
@@ -32,6 +32,8 @@ public function __construct(
3232
}
3333

3434
/**
35+
* Get HTML attributes
36+
*
3537
* @return string[]
3638
*/
3739
public function getHtmlAttributes()
@@ -53,6 +55,8 @@ public function getHtmlAttributes()
5355
}
5456

5557
/**
58+
* Get Element HTML
59+
*
5660
* @return string
5761
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
5862
*/
@@ -63,13 +67,15 @@ public function getElementHtml()
6367
} else {
6468
$this->unsetData('checked');
6569
}
70+
6671
return parent::getElementHtml();
6772
}
6873

6974
/**
7075
* Set check status of checkbox
7176
*
7277
* @param bool $value
78+
*
7379
* @return Checkbox
7480
*/
7581
public function setIsChecked($value = false)

lib/internal/Magento/Framework/Data/Form/Element/Checkboxes.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
/**
1111
* Form select element
12-
*
13-
* @author Magento Core Team <[email protected]>
1412
*/
1513
class Checkboxes extends AbstractElement
1614
{

lib/internal/Magento/Framework/Data/Form/Element/Collection.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
/**
1212
* Form element collection
13-
*
14-
* @author Magento Core Team <[email protected]>
1513
*/
1614
class Collection implements \ArrayAccess, \IteratorAggregate, \Countable
1715
{

lib/internal/Magento/Framework/Data/Form/Element/Column.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form column
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Date.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Magento data selector form element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210

1311
namespace Magento\Framework\Data\Form\Element;

lib/internal/Magento/Framework/Data/Form/Element/Editablemultiselect.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
@@ -8,8 +9,6 @@
89
* Form editable select element
910
*
1011
* Element allows inline modification of textual data within select
11-
*
12-
* @author Magento Core Team <[email protected]>
1312
*/
1413
namespace Magento\Framework\Data\Form\Element;
1514

@@ -70,7 +69,7 @@ public function __construct(
7069
*
7170
* This class must define init() method and receive configuration in the constructor
7271
*/
73-
const DEFAULT_ELEMENT_JS_CLASS = 'EditableMultiselect';
72+
public const DEFAULT_ELEMENT_JS_CLASS = 'EditableMultiselect';
7473

7574
/**
7675
* Retrieve HTML markup of the element
@@ -142,11 +141,12 @@ function check( tries, delay ){
142141
*
143142
* @param array $option
144143
* @param string[] $selected
144+
*
145145
* @return string
146146
*/
147147
protected function _optionToHtml($option, $selected)
148148
{
149-
$optionId = 'optId' .$this->random->getRandomString(8);
149+
$optionId = 'optId' . $this->random->getRandomString(8);
150150
$html = '<option value="' . $this->_escape($option['value']) . '" id="' . $optionId . '" ';
151151
$html .= isset($option['title']) ? 'title="' . $this->_escape($option['title']) . '"' : '';
152152
if (in_array((string)$option['value'], $selected)) {

lib/internal/Magento/Framework/Data/Form/Element/Editor.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414
/**
1515
* Form editor element
16-
*
17-
* @author Magento Core Team <[email protected]>
1816
*/
1917
class Editor extends Textarea
2018
{

lib/internal/Magento/Framework/Data/Form/Element/Fieldset.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
* Form fieldset
1313
*
1414
* @api
15-
* @author Magento Core Team <[email protected]>
1615
* @since 100.0.2
1716
*/
1817
class Fieldset extends AbstractElement

lib/internal/Magento/Framework/Data/Form/Element/File.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form file element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Gallery.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Category form input image element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Hidden.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
67

7-
/**
8-
* Form hidden element
9-
*
10-
* @author Magento Core Team <[email protected]>
11-
*/
128
namespace Magento\Framework\Data\Form\Element;
139

1410
use Magento\Framework\Escaper;
1511

12+
/**
13+
* Form hidden element
14+
*/
1615
class Hidden extends AbstractElement
1716
{
1817
/**
@@ -33,6 +32,8 @@ public function __construct(
3332
}
3433

3534
/**
35+
* Get default HTML
36+
*
3637
* @return mixed
3738
*/
3839
public function getDefaultHtml()
@@ -41,6 +42,7 @@ public function getDefaultHtml()
4142
if ($html === null) {
4243
$html = $this->getElementHtml();
4344
}
45+
4446
return $html;
4547
}
4648
}

lib/internal/Magento/Framework/Data/Form/Element/Imagefile.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form image file element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Link.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Magento Form element renderer to display link element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Multiline.php

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
67

78
/**
89
* Form multiline text elements
9-
*
10-
* @author Magento Core Team <[email protected]>
1110
*/
1211
namespace Magento\Framework\Data\Form\Element;
1312

@@ -33,6 +32,8 @@ public function __construct(
3332
}
3433

3534
/**
35+
* Get HTML attributes
36+
*
3637
* @return string[]
3738
*/
3839
public function getHtmlAttributes()
@@ -53,13 +54,17 @@ public function getHtmlAttributes()
5354
}
5455

5556
/**
57+
* Get label HTML
58+
*
5659
* @param int $suffix
5760
* @param string $scopeLabel
61+
*
5862
* @return string
5963
*/
6064
public function getLabelHtml($suffix = 0, $scopeLabel = '')
6165
{
62-
return parent::getLabelHtml($suffix, $scopeLabel);
66+
$html = parent::getLabelHtml($suffix, $scopeLabel);
67+
return $html;
6368
}
6469

6570
/**
@@ -78,6 +83,7 @@ public function getElementHtml()
7883
} else {
7984
$this->setClass('input-text admin__control-text');
8085
}
86+
8187
$html .= '<div class="multi-input admin__field-control"><input id="' .
8288
$this->getHtmlId() .
8389
$i .
@@ -97,12 +103,16 @@ public function getElementHtml()
97103
if ($i == 0) {
98104
$html .= $this->getAfterElementHtml();
99105
}
106+
100107
$html .= '</div>';
101108
}
109+
102110
return $html;
103111
}
104112

105113
/**
114+
* Get default HTML
115+
*
106116
* @return mixed
107117
* @SuppressWarnings(PHPMD.NPathComplexity)
108118
*/
@@ -129,6 +139,7 @@ public function getDefaultHtml()
129139
$this->setClass('input-text');
130140
$html .= '<label>&nbsp;</label>' . "\n";
131141
}
142+
132143
$html .= '<input id="' .
133144
$this->getHtmlId() .
134145
$i .
@@ -146,13 +157,15 @@ public function getDefaultHtml()
146157
if ($i == 0) {
147158
$html .= $this->getAfterElementHtml();
148159
}
160+
149161
$html .= $this->getNoSpan() === true ? '' : '</span>' . "\n";
150162
}
163+
151164
return $html;
152165
}
153166

154167
/**
155-
* {@inheritdoc}
168+
* @inheritDoc
156169
*/
157170
public function getEscapedValue($index = null)
158171
{

lib/internal/Magento/Framework/Data/Form/Element/Multiselect.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form select element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Note.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
<?php
2+
23
/**
34
* Copyright © Magento, Inc. All rights reserved.
45
* See COPYING.txt for license details.
56
*/
67

7-
/**
8-
* Form note element
9-
*
10-
* @author Magento Core Team <[email protected]>
11-
*/
128
namespace Magento\Framework\Data\Form\Element;
139

1410
use Magento\Framework\Escaper;
1511

12+
/**
13+
* Form note element
14+
*/
1615
class Note extends AbstractElement
1716
{
1817
/**
@@ -32,6 +31,8 @@ public function __construct(
3231
}
3332

3433
/**
34+
* Get element HTML
35+
*
3536
* @return string
3637
*/
3738
public function getElementHtml()

lib/internal/Magento/Framework/Data/Form/Element/Obscure.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form text element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Password.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form password element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

lib/internal/Magento/Framework/Data/Form/Element/Radio.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
/**
88
* Form radio element
9-
*
10-
* @author Magento Core Team <[email protected]>
119
*/
1210
namespace Magento\Framework\Data\Form\Element;
1311

0 commit comments

Comments
 (0)