fix: make file matcher respect the hidden option (#1936)

* Extend test with a hidden file

* fix: make file matcher respect the hidden option

* Update test

Author: thomas-zahner

fixtures/hidden/.file.md

@@ -0,0 +1 @@
+https://rust-lang.org

fixtures/hidden/.hidden/file.md

@@ -1 +1 @@
-https://wikipedia.org
+https://rust-lang.org

lychee-bin/tests/cli.rs

@@ -685,23 +685,19 @@ mod cli {
             .arg("--hidden")
             .assert()
             .success()
-            .stdout(contains("1 Total"));
+            .stdout(contains("2 Total"));
 
-        cargo_bin_cmd!()
+        let result = cargo_bin_cmd!()
             .arg("--dump")
             .arg("--hidden")
             .arg(fixtures_path!().join("hidden/"))
             .assert()
-            .stdout(contains("wikipedia.org"))
             .success();
 
-        cargo_bin_cmd!()
-            .arg("--dump-inputs")
-            .arg("--hidden")
-            .arg(fixtures_path!().join("hidden/"))
-            .assert()
-            .stdout(contains(".hidden"))
-            .success();
+        assert_lines_eq(
+            result,
+            vec!["https://rust-lang.org/", "https://rust-lang.org/"],
+        );
     }
 
     #[test]
@@ -2058,7 +2054,8 @@ The config file should contain every possible key for documentation purposes."
             .arg(test_dir)
             .assert()
             .success()
-            .stdout(contains(".hidden/file.md"));
+            .stdout(contains("hidden/.file.md"))
+            .stdout(contains("hidden/.hidden/file.md"));
     }
 
     #[test]

lychee-lib/src/types/file.rs

@@ -46,21 +46,19 @@ impl FileExtensions {
     pub fn contains<T: Into<String>>(&self, file_extension: T) -> bool {
         self.0.contains(&file_extension.into())
     }
-}
-
-impl TryFrom<FileExtensions> for Types {
-    type Error = super::ErrorKind;
 
     /// Build the current list of file extensions into a file type matcher.
     ///
     /// # Errors
     ///
     /// Fails if an extension is `all` or otherwise contains any character that
     /// is not a Unicode letter or number.
-    fn try_from(value: FileExtensions) -> super::Result<Self> {
+    pub fn build(self, skip_hidden: bool) -> super::Result<Types> {
         let mut types_builder = TypesBuilder::new();
-        for ext in value.0.clone() {
-            types_builder.add(&ext, &format!("*.{ext}"))?;
+        let prefix = if skip_hidden { "[!.]" } else { "" };
+
+        for ext in self.0 {
+            types_builder.add(&ext, &format!("{prefix}*.{ext}"))?;
         }
         Ok(types_builder.select("all").build()?)
     }

lychee-lib/src/types/input/resolver.rs

@@ -88,7 +88,7 @@ impl InputResolver {
             // Ignore hidden files if necessary
             .hidden(skip_hidden)
             // Configure the file types filter to only include files with matching extensions
-            .types(file_extensions.try_into()?)
+            .types(file_extensions.build(skip_hidden)?)
             .build())
     }