chore: more streamline of static and base group manager

Author: darshankabariya

waku/waku_rln_relay/group_manager/group_manager_base.nim

@@ -40,13 +40,6 @@ type GroupManager* = ref object of RootObj
 method init*(g: GroupManager): Future[GroupManagerResult[void]] {.base, async.} =
   return err("init proc for " & $g.type & " is not implemented yet")
 
-# This proc is used to start the group sync process
-# It should be used to sync the group state with the rest of the group members
-method startGroupSync*(
-    g: GroupManager
-): Future[GroupManagerResult[void]] {.base, async.} =
-  return err("startGroupSync proc for " & $g.type & " is not implemented yet")
-
 # This proc is used to register a new identity commitment into the merkle tree
 # The user may or may not have the identity secret to this commitment
 # It should be used when detecting new members in the group, and syncing the group state

waku/waku_rln_relay/group_manager/on_chain/group_manager.nim

@@ -278,11 +278,6 @@ method withdraw*(
 ): Future[void] {.async: (raises: [Exception]).} =
   initializedGuard(g) # TODO: after slashing is enabled on the contract
 
-method withdrawBatch*(
-    g: OnchainGroupManager, idCommitments: seq[IDCommitment]
-): Future[void] {.async: (raises: [Exception]).} =
-  initializedGuard(g)
-
 proc getRootFromProofAndIndex(
     g: OnchainGroupManager, elements: seq[byte], bits: seq[byte]
 ): GroupManagerResult[array[32, byte]] =

waku/waku_rln_relay/group_manager/static/group_manager.nim

@@ -45,7 +45,7 @@ method init*(g: StaticGroupManager): Future[GroupManagerResult[void]] {.async.}
 
 method startGroupSync*(
     g: StaticGroupManager
-): Future[GroupManagerResult[void]] {.async.} =
+): Future[GroupManagerResult[void]] {.base, async.} =
   ?g.resultifiedInitGuard()
   # No-op
   return ok()

waku/waku_rln_relay/rln/wrappers.nim

@@ -63,7 +63,6 @@ type RlnTreeConfig = ref object of RootObj
   mode: string
   compression: bool
   flush_every_ms: int
-  path: string
 
 type RlnConfig = ref object of RootObj
   resources_folder: string
@@ -78,7 +77,6 @@ proc `%`(c: RlnConfig): JsonNode =
       "mode": %c.tree_config.mode,
       "compression": %c.tree_config.compression,
       "flush_every_ms": %c.tree_config.flush_every_ms,
-      "path": %c.tree_config.path,
     }
   return %[("resources_folder", %c.resources_folder), ("tree_config", %tree_config)]