Fix detecting mocha config calls in no-setup-in-describe

Author: lo1tuma

.c8rc.json

@@ -1,7 +1,7 @@
 {
     "all": true,
-    "lines": 98.34,
-    "statements": 98.34,
+    "lines": 98.33,
+    "statements": 98.33,
     "functions": 99.6,
     "branches": 94.8,
     "check-coverage": true,

source/rules/no-setup-in-describe.test.ts

@@ -109,6 +109,16 @@ ruleTester.run('no-setup-in-describe', noSetupInDescribeRule, {
     ],
 
     invalid: [
+        {
+            code: 'suite("", function () { this.timeout(42); a(); });',
+            errors: [
+                {
+                    message: 'Unexpected function call in describe block.',
+                    line: 1,
+                    column: 43
+                }
+            ]
+        },
         {
             code: 'suite("", function () { a(); });',
             errors: [

source/rules/no-setup-in-describe.ts

@@ -5,12 +5,10 @@ import { isSuiteConfigCall } from '../mocha/config-call.js';
 
 const FUNCTION = 1;
 const DESCRIBE = 2;
-const PURE = 3;
 
 function isNestedInDescribeBlock(nesting: readonly number[]): boolean {
     return (
         nesting.length > 0 &&
-        !nesting.includes(PURE) &&
         nesting.lastIndexOf(FUNCTION) < nesting.lastIndexOf(DESCRIBE)
     );
 }
@@ -51,9 +49,7 @@ export const noSetupInDescribeRule: Readonly<Rule.RuleModule> = {
         const suiteNodes = new WeakSet();
 
         function handleCallExpressionInDescribe(node: Readonly<CallExpression>): void {
-            if (isSuiteConfigCall(node)) {
-                nesting.push(PURE);
-            } else if (isNestedInDescribeBlock(nesting)) {
+            if (isNestedInDescribeBlock(nesting) && !isSuiteConfigCall(node)) {
                 reportCallExpression(context, node);
             }
         }
@@ -78,7 +74,8 @@ export const noSetupInDescribeRule: Readonly<Rule.RuleModule> = {
             nonMochaMemberExpression(node) {
                 if (
                     !suiteNodes.has(node.parent) &&
-                    isNestedInDescribeBlock(nesting)
+                    isNestedInDescribeBlock(nesting) &&
+                    !isSuiteConfigCall(node.parent)
                 ) {
                     reportMemberExpression(context, node);
                 }