[NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes #66295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easy for callers to see issues with and fix up calls to createTargetMachine after a future change to the params of TargetMachine. This matches other enums in the CodeGenOpt namespace. For downstream users, this should be a fairly straightforward replacement, e.g. s/CodeGenOpt::Aggressive/CodeGenOpt::Level::Aggressive or s/CodeGenOpt::CGFT_Null/CodeGenOpt::FileType::Null
llvmbot
added
clang
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 22, 2023
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: #109408 Approved by: https://github.com/Skylion007
dstutt
added a commit
to dstutt/llpc
that referenced
this pull request
Sep 27, 2023
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Changes were made in GPUOpen-Drivers#2770 but some unit tests were missed.
dstutt
added a commit
to GPUOpen-Drivers/llpc
that referenced
this pull request
Sep 28, 2023
There is a flag-day change around CodeGen enums in llvm/llvm-project#66295. Changes were made in #2707 but some unit tests were missed.
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: pytorch#109408 Approved by: https://github.com/Skylion007
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: pytorch#109408 Approved by: https://github.com/Skylion007
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 6, 2023
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: pytorch#109408 Approved by: https://github.com/Skylion007
quic-sanirudh
added a commit
to quic-sanirudh/tvm
that referenced
this pull request
Oct 12, 2023
This patch fixes the errors caused due to recent API change from LLVM for CodeGenOpt made in [this PR](llvm/llvm-project#66295)
Hzfengsy
pushed a commit
to apache/tvm
that referenced
this pull request
Oct 13, 2023
This patch fixes the errors caused due to recent API change from LLVM for CodeGenOpt made in [this PR](llvm/llvm-project#66295)
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Nov 17, 2023
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: pytorch#109408 Approved by: https://github.com/Skylion007
jeffdaily
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jan 5, 2024
Summary: llvm/llvm-project#66295 modified some internal LLVM APIs, update these places with the changes under LLVM version guard Test Plan: CI Differential Revision: D49340871 Pull Request resolved: pytorch#109408 Approved by: https://github.com/Skylion007
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Apr 21, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
May 3, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
May 3, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
May 4, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
May 4, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 18, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 18, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 20, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 20, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 21, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jun 21, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jul 21, 2024
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Jul 21, 2024
hubot
pushed a commit
to google/swiftshader
that referenced
this pull request
Apr 28, 2025
Relevant LLVM API changes: llvm/llvm-project#66295 llvm/llvm-project#71029 llvm/llvm-project#74261 Change-Id: Id5af421c1415cf231dcb6673fa3c3b6f5b106841 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/73168 Reviewed-by: Geoff Lang <[email protected]> Tested-by: Shahbaz Youssefi <[email protected]> Reviewed-by: Shahbaz Youssefi <[email protected]> Commit-Queue: Shahbaz Youssefi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easy for callers to see issues with and fix up calls
to createTargetMachine after a future change to the params of
TargetMachine.
This matches other nearby enums.
For downstream users, this should be a fairly straightforward replacement,
e.g. s/CodeGenOpt::Aggressive/CodeGenOptLevel::Aggressive
or s/CGFT_/CodeGenFileType::