Skip to content

Commit e86e30a

Browse files
committed
[llvm] manual fix-ups to IDS codemod of SandboxIR library
1 parent 350db36 commit e86e30a

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

llvm/include/llvm/SandboxIR/Constant.h

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1060,6 +1060,17 @@ class GlobalWithNodeAPI : public ParentT {
10601060
}
10611061
};
10621062

1063+
// Explicit instantiations.
1064+
extern template class LLVM_TEMPLATE_ABI GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
1065+
llvm::GlobalObject>;
1066+
extern template class LLVM_TEMPLATE_ABI GlobalWithNodeAPI<Function, llvm::Function, GlobalObject,
1067+
llvm::GlobalObject>;
1068+
extern template class LLVM_TEMPLATE_ABI GlobalWithNodeAPI<GlobalVariable, llvm::GlobalVariable,
1069+
GlobalObject, llvm::GlobalObject>;
1070+
extern template class LLVM_TEMPLATE_ABI GlobalWithNodeAPI<GlobalAlias, llvm::GlobalAlias, GlobalValue,
1071+
llvm::GlobalValue>;
1072+
1073+
#if defined(_MSC_VER) && !defined(__clang__)
10631074
// These are needed for SandboxIRTest when building with LLVM_BUILD_LLVM_DYLIB
10641075
extern template LLVM_TEMPLATE_ABI GlobalIFunc &
10651076
GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
@@ -1078,6 +1089,7 @@ extern template LLVM_TEMPLATE_ABI GlobalAlias &
10781089
GlobalWithNodeAPI<GlobalAlias, llvm::GlobalAlias, GlobalValue,
10791090
llvm::GlobalValue>::LLVMGVToGV::operator()(llvm::GlobalAlias
10801091
&LLVMGV) const;
1092+
#endif
10811093

10821094
class GlobalIFunc final
10831095
: public GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,

llvm/include/llvm/SandboxIR/Tracker.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
#include "llvm/IR/IRBuilder.h"
4848
#include "llvm/IR/Instruction.h"
4949
#include "llvm/SandboxIR/Use.h"
50+
#include "llvm/SandboxIR/Value.h"
5051
#include "llvm/Support/Debug.h"
5152
#include <memory>
5253

llvm/lib/SandboxIR/Constant.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,13 +305,13 @@ GlobalT &GlobalWithNodeAPI<GlobalT, LLVMGlobalT, ParentT, LLVMParentT>::
305305
}
306306

307307
// Explicit instantiations.
308-
template class GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
308+
template class LLVM_EXPORT_TEMPLATE GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
309309
llvm::GlobalObject>;
310-
template class GlobalWithNodeAPI<Function, llvm::Function, GlobalObject,
310+
template class LLVM_EXPORT_TEMPLATE GlobalWithNodeAPI<Function, llvm::Function, GlobalObject,
311311
llvm::GlobalObject>;
312-
template class GlobalWithNodeAPI<GlobalVariable, llvm::GlobalVariable,
312+
template class LLVM_EXPORT_TEMPLATE GlobalWithNodeAPI<GlobalVariable, llvm::GlobalVariable,
313313
GlobalObject, llvm::GlobalObject>;
314-
template class GlobalWithNodeAPI<GlobalAlias, llvm::GlobalAlias, GlobalValue,
314+
template class LLVM_EXPORT_TEMPLATE GlobalWithNodeAPI<GlobalAlias, llvm::GlobalAlias, GlobalValue,
315315
llvm::GlobalValue>;
316316

317317
#if defined(_MSC_VER) && !defined(__clang__)

0 commit comments

Comments
 (0)