Skip to content

Commit b5c1d3a

Browse files
committed
Address final review comments.
1 parent e01ce4c commit b5c1d3a

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

libcxx/include/__chrono/tzdb_list.h

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@
1818

1919
# include <__availability>
2020
# include <__chrono/tzdb.h>
21+
# include <__config>
22+
# include <__fwd/string.h>
2123
# include <forward_list>
22-
# include <string>
2324

2425
# if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
2526
# pragma GCC system_header
@@ -41,7 +42,9 @@ namespace chrono {
4142
class _LIBCPP_AVAILABILITY_TZDB tzdb_list {
4243
public:
4344
class __impl; // public to allow construction in dylib
44-
_LIBCPP_EXPORTED_FROM_ABI explicit tzdb_list(__impl* __p);
45+
_LIBCPP_HIDE_FROM_ABI explicit tzdb_list(__impl* __p) : __impl_(__p) {
46+
_LIBCPP_ASSERT_NON_NULL(__impl_ != nullptr, "initialized time_zone without a valid pimpl object");
47+
}
4548
_LIBCPP_EXPORTED_FROM_ABI ~tzdb_list();
4649

4750
tzdb_list(const tzdb_list&) = delete;

libcxx/src/tzdb_list.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ _LIBCPP_BEGIN_NAMESPACE_STD
1616

1717
namespace chrono {
1818

19-
_LIBCPP_EXPORTED_FROM_ABI tzdb_list::tzdb_list(tzdb_list::__impl* __p) : __impl_(__p) {
20-
_LIBCPP_ASSERT_NON_NULL(__impl_ != nullptr, "initialized time_zone without a valid pimpl object");
21-
}
22-
2319
_LIBCPP_EXPORTED_FROM_ABI tzdb_list::~tzdb_list() { delete __impl_; }
2420

2521
_LIBCPP_NODISCARD_EXT _LIBCPP_EXPORTED_FROM_ABI const tzdb& tzdb_list::front() const noexcept {

0 commit comments

Comments
 (0)