[MC] Change Subsection parameters from const MCExpr * to uint32_t

Follow-up to 05ba5c0. uint32_t is
preferred over const MCExpr * in the section stack uses because it
should only be evaluated once. Change the paramter type to match.

Author: MaskRay

llvm/include/llvm/MC/MCContext.h

@@ -600,7 +600,7 @@ class MCContext {
                                                    unsigned EntrySize);
 
   MCSectionGOFF *getGOFFSection(StringRef Section, SectionKind Kind,
-                                MCSection *Parent, const MCExpr *SubsectionId);
+                                MCSection *Parent, uint32_t Subsection = 0);
 
   MCSectionCOFF *getCOFFSection(StringRef Section, unsigned Characteristics,
                                 StringRef COMDATSymName, int Selection,

llvm/include/llvm/MC/MCELFStreamer.h

@@ -46,7 +46,7 @@ class MCELFStreamer : public MCObjectStreamer {
   /// @{
 
   void initSections(bool NoExecStack, const MCSubtargetInfo &STI) override;
-  void changeSection(MCSection *Section, const MCExpr *Subsection) override;
+  void changeSection(MCSection *Section, uint32_t Subsection) override;
   void emitLabel(MCSymbol *Symbol, SMLoc Loc = SMLoc()) override;
   void emitLabelAtPos(MCSymbol *Symbol, SMLoc Loc, MCDataFragment &F,
                       uint64_t Offset) override;

llvm/include/llvm/MC/MCObjectStreamer.h

@@ -101,7 +101,7 @@ class MCObjectStreamer : public MCStreamer {
   MCDataFragment *getOrCreateDataFragment(const MCSubtargetInfo* STI = nullptr);
 
 protected:
-  bool changeSectionImpl(MCSection *Section, const MCExpr *Subsection);
+  bool changeSectionImpl(MCSection *Section, uint32_t Subsection);
 
 public:
   void visitUsedSymbol(const MCSymbol &Sym) override;
@@ -122,7 +122,7 @@ class MCObjectStreamer : public MCStreamer {
   void emitULEB128Value(const MCExpr *Value) override;
   void emitSLEB128Value(const MCExpr *Value) override;
   void emitWeakReference(MCSymbol *Alias, const MCSymbol *Symbol) override;
-  void changeSection(MCSection *Section, const MCExpr *Subsection) override;
+  void changeSection(MCSection *Section, uint32_t Subsection) override;
   void emitInstruction(const MCInst &Inst, const MCSubtargetInfo &STI) override;
 
   /// Emit an instruction to a special fragment, because this instruction

llvm/include/llvm/MC/MCSection.h

@@ -211,7 +211,7 @@ class MCSection {
 
   virtual void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                                     raw_ostream &OS,
-                                    const MCExpr *Subsection) const = 0;
+                                    uint32_t Subsection) const = 0;
 
   /// Return true if a .align directive should use "optimized nops" to fill
   /// instead of 0s.

llvm/include/llvm/MC/MCSectionCOFF.h

@@ -73,7 +73,7 @@ class MCSectionCOFF final : public MCSection {
 
   void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                             raw_ostream &OS,
-                            const MCExpr *Subsection) const override;
+                            uint32_t Subsection) const override;
   bool useCodeAlign() const override;
   bool isVirtualSection() const override;
   StringRef getVirtualSectionKind() const override;

llvm/include/llvm/MC/MCSectionDXContainer.h

@@ -28,7 +28,7 @@ class MCSectionDXContainer final : public MCSection {
 
 public:
   void printSwitchToSection(const MCAsmInfo &, const Triple &, raw_ostream &,
-                            const MCExpr *) const override;
+                            uint32_t) const override;
   bool useCodeAlign() const override { return false; }
   bool isVirtualSection() const override { return false; }
 };

llvm/include/llvm/MC/MCSectionELF.h

@@ -79,7 +79,7 @@ class MCSectionELF final : public MCSection {
 
   void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                             raw_ostream &OS,
-                            const MCExpr *Subsection) const override;
+                            uint32_t Subsection) const override;
   bool useCodeAlign() const override;
   bool isVirtualSection() const override;
   StringRef getVirtualSectionKind() const override;

llvm/include/llvm/MC/MCSectionGOFF.h

@@ -26,17 +26,17 @@ class MCExpr;
 class MCSectionGOFF final : public MCSection {
 private:
   MCSection *Parent;
-  const MCExpr *SubsectionId;
+  uint32_t Subsection;
 
   friend class MCContext;
-  MCSectionGOFF(StringRef Name, SectionKind K, MCSection *P, const MCExpr *Sub)
+  MCSectionGOFF(StringRef Name, SectionKind K, MCSection *P, uint32_t Sub)
       : MCSection(SV_GOFF, Name, K.isText(), nullptr), Parent(P),
-        SubsectionId(Sub) {}
+        Subsection(Sub) {}
 
 public:
   void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                             raw_ostream &OS,
-                            const MCExpr *Subsection) const override {
+                            uint32_t /*Subsection*/) const override {
     OS << "\t.section\t\"" << getName() << "\"\n";
   }
 
@@ -45,7 +45,7 @@ class MCSectionGOFF final : public MCSection {
   bool isVirtualSection() const override { return false; }
 
   MCSection *getParent() const { return Parent; }
-  const MCExpr *getSubsectionId() const { return SubsectionId; }
+  uint32_t getSubsection() const { return Subsection; }
 
   static bool classof(const MCSection *S) { return S->getVariant() == SV_GOFF; }
 };

llvm/include/llvm/MC/MCSectionMachO.h

@@ -73,7 +73,7 @@ class MCSectionMachO final : public MCSection {
 
   void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                             raw_ostream &OS,
-                            const MCExpr *Subsection) const override;
+                            uint32_t Subsection) const override;
   bool useCodeAlign() const override;
   bool isVirtualSection() const override;
 

llvm/include/llvm/MC/MCSectionSPIRV.h

@@ -31,7 +31,7 @@ class MCSectionSPIRV final : public MCSection {
   ~MCSectionSPIRV() = default;
   void printSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
                             raw_ostream &OS,
-                            const MCExpr *Subsection) const override {}
+                            uint32_t Subsection) const override {}
   bool useCodeAlign() const override { return false; }
   bool isVirtualSection() const override { return false; }
 };