Skip to content

Commit 0fdef5f

Browse files
authored
Revert " Reland "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)" Attempt 2…"
This reverts commit 68c8c8c.
1 parent 7f66a83 commit 0fdef5f

19 files changed

+15
-918
lines changed

lldb/cmake/modules/LLDBConfig.cmake

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -323,23 +323,4 @@ else()
323323
set(LLDB_CAN_USE_DEBUGSERVER OFF)
324324
endif()
325325

326-
# In a cross-compile build, we need to skip building the generated
327-
# lldb-rpc sources in the first phase of host build so that they can
328-
# get built using the just-built Clang toolchain in the second phase.
329-
if (NOT DEFINED LLDB_CAN_USE_LLDB_RPC_SERVER)
330-
if ((CMAKE_CROSSCOMPILING OR LLVM_HOST_TRIPLE MATCHES "${LLVM_DEFAULT_TARGET_TRIPLE}") AND
331-
CMAKE_SYSTEM_NAME MATCHES "AIX|Android|Darwin|FreeBSD|Linux|NetBSD|OpenBSD|Windows")
332-
set(LLDB_CAN_USE_LLDB_RPC_SERVER ON)
333-
else()
334-
set(LLDB_CAN_USE_LLDB_RPC_SERVER OFF)
335-
endif()
336-
endif()
337-
338-
if (CMAKE_CROSSCOMPILING)
339-
set(LLDB_BUILD_LLDBRPC OFF CACHE BOOL "")
340-
get_host_tool_path(lldb-rpc-gen LLDB_RPC_GEN_EXE lldb_rpc_gen_exe lldb_rpc_gen_target)
341-
else()
342-
set(LLDB_BUILD_LLDBRPC ON CACHE BOOL "")
343-
endif()
344-
345326
include(LLDBGenerateConfig)

lldb/test/CMakeLists.txt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@ if(TARGET lldb-framework)
132132
add_lldb_test_dependency(lldb-framework)
133133
endif()
134134

135-
if (LLDB_CAN_USE_LLDB_RPC_SERVER)
136-
add_lldb_test_dependency(lldb-rpc-generate-sources)
137-
endif()
138-
139135
# Add dependencies that are not exported targets when building standalone.
140136
if(NOT LLDB_BUILT_STANDALONE)
141137
add_lldb_test_dependency(
@@ -253,8 +249,7 @@ llvm_canonicalize_cmake_booleans(
253249
LLDB_TEST_SHELL_DISABLE_REMOTE
254250
LLDB_TOOL_LLDB_SERVER_BUILD
255251
LLDB_USE_SYSTEM_DEBUGSERVER
256-
LLDB_IS_64_BITS
257-
LLDB_BUILD_LLDBRPC)
252+
LLDB_IS_64_BITS)
258253

259254
# Configure the individual test suites.
260255
add_subdirectory(API)

lldb/test/Shell/RPC/Generator/Inputs/SBDummy.h

Whitespace-only changes.

lldb/test/Shell/RPC/Generator/Tests/CheckRPCGenToolByproducts.test

Lines changed: 0 additions & 9 deletions
This file was deleted.

lldb/test/Shell/RPC/Generator/lit.local.cfg

Lines changed: 0 additions & 3 deletions
This file was deleted.

lldb/test/Shell/helper/toolchain.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -156,16 +156,6 @@ def use_lldb_substitutions(config):
156156
extra_args=["platform"],
157157
unresolved="ignore",
158158
),
159-
ToolSubst(
160-
"%lldb-rpc-gen",
161-
command=FindTool("lldb-rpc-gen"),
162-
# We need the LLDB build directory root to pass into the tool, not the test build root.
163-
extra_args=[
164-
"-p " + config.lldb_build_directory + "/..",
165-
'--extra-arg="-resource-dir=' + config.clang_resource_dir + '"',
166-
],
167-
unresolved="ignore",
168-
),
169159
"lldb-test",
170160
"lldb-dap",
171161
ToolSubst(

lldb/test/Shell/lit.site.cfg.py.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ config.lldb_build_directory = "@LLDB_TEST_BUILD_DIRECTORY@"
3333
config.have_lldb_server = @LLDB_TOOL_LLDB_SERVER_BUILD@
3434
config.lldb_system_debugserver = @LLDB_USE_SYSTEM_DEBUGSERVER@
3535
config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@"
36-
config.lldb_has_lldbrpc = @LLDB_BUILD_LLDBRPC@
3736
# The shell tests use their own module caches.
3837
config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell")
3938
config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell")

lldb/tools/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ add_subdirectory(lldb-fuzzer EXCLUDE_FROM_ALL)
1010

1111
add_lldb_tool_subdirectory(lldb-instr)
1212
add_lldb_tool_subdirectory(lldb-dap)
13-
if (LLDB_BUILD_LLDBRPC)
14-
add_lldb_tool_subdirectory(lldb-rpc-gen)
15-
endif()
16-
if (LLDB_CAN_USE_LLDB_RPC_SERVER)
17-
add_subdirectory(lldb-rpc)
18-
endif()
1913

2014
if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
2115
add_lldb_tool_subdirectory(darwin-debug)

lldb/tools/lldb-rpc-gen/CMakeLists.txt

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)