chore: llvm old

Author: luisacicolini

.github/bin/uploadReleaseArtifacts.sh

@@ -134,8 +134,12 @@ mapfile -t OPT_OS < <(echo "${OPT_OS[@]}" | tr ' ' '\n' | sort -u)
 # For non-full installs, install the following tools.
 binaries=(
     circt-opt
+    circt-reduce
     circt-synth
     circt-test
+    circt-translate
+    circt-verilog
+    domaintool
     firtool
     om-linker
 )
@@ -173,7 +177,7 @@ EOF
 configMacOsRunner=$(cat <<EOF
 [
   {
-    "runner": "macos-13",
+    "runner": "macos-15-intel",
     "cmake_c_compiler": "clang",
     "cmake_cxx_compiler": "clang++"
   }

.github/copilot-instructions.md

@@ -0,0 +1,20 @@
+# Copilot build & test guidance
+
+- Default to the integration docker image in `CIRCT_INTEGRATION_IMAGE` (set by the Copilot setup workflow and the `utils/run-docker.sh` default; currently `ghcr.io/circt/images/circt-integration-test:v19.2`) when compiling or testing.
+- Run inside that image via `./utils/run-docker.sh ./utils/run-tests-docker.sh "$CIRCT_INTEGRATION_IMAGE"` or `docker run` with the repo root bind-mounted.
+- When cloning or checking out, ensure submodules are present (`git submodule update --init --recursive` if needed).
+- Configure builds from the repo root with Ninja, matching the README:
+  ```
+  cmake -G Ninja llvm/llvm -B build \
+    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+    -DLLVM_ENABLE_ASSERTIONS=ON \
+    -DLLVM_TARGETS_TO_BUILD=host \
+    -DLLVM_ENABLE_PROJECTS=mlir \
+    -DLLVM_EXTERNAL_PROJECTS=circt \
+    -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=$PWD \
+    -DLLVM_ENABLE_LLD=ON
+  ```
+- Build everything with `ninja -C build check-circt`; use `ninja -C build bin/circt-opt` or `ninja -C build bin/firtool` for tool-only builds.
+- Keep Python bindings enabled when needed via `-DMLIR_ENABLE_BINDINGS_PYTHON=ON -DCIRCT_BINDINGS_PYTHON_ENABLED=ON`.
+- For PyCDE and the ESI runtime, add `-DCIRCT_ENABLE_FRONTENDS=PyCDE -DESI_RUNTIME=ON` (keep Python bindings on). Test with `ninja -C build check-pycde` (PyCDE only) and `ninja -C build check-pycde-integration` (these integration tests exercise both PyCDE and the ESI runtime and are the only ESIRuntime tests).
+- Prefer the integration image and the setup steps workflow for reliable dependencies; only fall back to host builds when explicitly requested.

.github/workflows/copilot-setup-steps.yml

@@ -0,0 +1,28 @@
+name: Copilot setup steps
+
+on:
+  workflow_dispatch:
+  push:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+
+permissions:
+  contents: read
+
+jobs:
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Pre-pull integration docker image
+        env:
+          CIRCT_INTEGRATION_IMAGE: ghcr.io/circt/images/circt-integration-test:v19.2
+        run: |
+          echo "CIRCT_INTEGRATION_IMAGE=$CIRCT_INTEGRATION_IMAGE" >> $GITHUB_ENV
+          docker pull "$CIRCT_INTEGRATION_IMAGE"
+      - name: Summarize defaults
+        run: |
+          {
+            echo "### CIRCT Copilot setup"
+            echo "- Integration image: $CIRCT_INTEGRATION_IMAGE"
+            echo "- Default build directory: build"
+          } >> "$GITHUB_STEP_SUMMARY"

.github/workflows/esiRuntimePublish.yml

@@ -17,8 +17,6 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - os: ubuntu-24.04
-            cibw_build: cp38-manylinux_x86_64
           - os: ubuntu-24.04
             cibw_build: cp39-manylinux_x86_64
           - os: ubuntu-24.04
@@ -29,8 +27,8 @@ jobs:
             cibw_build: cp312-manylinux_x86_64
           - os: ubuntu-24.04
             cibw_build: cp313-manylinux_x86_64
-          - os: windows-2022
-            cibw_build: cp38-win_amd64
+          - os: ubuntu-24.04
+            cibw_build: cp314-manylinux_x86_64
           - os: windows-2022
             cibw_build: cp39-win_amd64
           - os: windows-2022
@@ -41,6 +39,8 @@ jobs:
             cibw_build: cp312-win_amd64
           - os: windows-2022
             cibw_build: cp313-win_amd64
+          - os: windows-2022
+            cibw_build: cp314-win_amd64
 
     steps:
       - name: Get CIRCT
@@ -68,7 +68,7 @@ jobs:
           & "${env:VCPKG_INSTALLATION_ROOT}/vcpkg" --triplet x64-windows install zlib grpc
 
       - name: Install cibuildwheel
-        run: python -m pip install cibuildwheel==2.23.3
+        run: python -m pip install cibuildwheel==3.3.0
 
       - name: Build wheels
         if: runner.os != 'Windows'

.github/workflows/nightlyIntegrationTests.yml

@@ -19,7 +19,7 @@ jobs:
     # John and re-run the job.
     runs-on: ["self-hosted", "1ES.Pool=1ES-CIRCT-builds", "linux"]
     container:
-      image: ghcr.io/circt/images/circt-integration-test:v19
+      image: ghcr.io/circt/images/circt-integration-test:v19.2
       volumes:
         - /mnt:/__w/circt
     strategy:

.github/workflows/shortIntegrationTests.yml

@@ -31,7 +31,7 @@ jobs:
     outputs:
       cache-key-pattern: ${{ steps.cache-key.outputs.pattern }}
     container:
-      image: ghcr.io/circt/images/circt-integration-test:v19
+      image: ghcr.io/circt/images/circt-integration-test:v19.2
       volumes:
         - /mnt:/__w/circt
     strategy:

.github/workflows/unifiedBuildTestAndInstall.yml

@@ -208,7 +208,7 @@ jobs:
           ${{ steps.setup-windows.outputs.setup }}
           mkdir build
           cd build
-          cmake -G Ninja -S "$(pwd)/../llvm/llvm" $EXTRA_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} -DBUILD_SHARED_LIBS=${{ inputs.build_shared_libs }} -DLLVM_BUILD_TOOLS=ON -DLLVM_BUILD_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=${{ inputs.llvm_enable_assertions }} -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_EXTERNAL_PROJECTS=circt -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=".." -DLLVM_STATIC_LINK_CXX_STDLIB=ON -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_TARGETS_TO_BUILD="host" -DLLVM_FORCE_ENABLE_STATS=${{ inputs.llvm_force_enable_stats }} -DLLVM_ENABLE_ZSTD=OFF -DVERILATOR_DISABLE=ON -DCIRCT_RELEASE_TAG_ENABLED=ON -DCIRCT_RELEASE_TAG=firtool -DCMAKE_EXPORT_COMPILE_COMMANDS=OFF -DCMAKE_C_COMPILER=${{ inputs.cmake_c_compiler }} -DCMAKE_CXX_COMPILER=${{ inputs.cmake_cxx_compiler }} ${{ steps.configure-sccache.outputs.enable_sccache }} -DCMAKE_INSTALL_PREFIX="$(pwd)/../install" -DLLVM_INSTALL_UTILS=ON
+          cmake -G Ninja -S "$(pwd)/../llvm/llvm" $EXTRA_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} -DBUILD_SHARED_LIBS=${{ inputs.build_shared_libs }} -DLLVM_BUILD_TOOLS=ON -DLLVM_BUILD_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=${{ inputs.llvm_enable_assertions }} -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_EXTERNAL_PROJECTS=circt -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=".." -DLLVM_STATIC_LINK_CXX_STDLIB=ON -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_TARGETS_TO_BUILD="host" -DLLVM_FORCE_ENABLE_STATS=${{ inputs.llvm_force_enable_stats }} -DLLVM_ENABLE_ZSTD=OFF -DVERILATOR_DISABLE=ON -DCIRCT_RELEASE_TAG_ENABLED=ON -DCIRCT_RELEASE_TAG=firtool -DCMAKE_EXPORT_COMPILE_COMMANDS=OFF -DCMAKE_C_COMPILER=${{ inputs.cmake_c_compiler }} -DCMAKE_CXX_COMPILER=${{ inputs.cmake_cxx_compiler }} ${{ steps.configure-sccache.outputs.enable_sccache }} -DCMAKE_INSTALL_PREFIX="$(pwd)/../install" -DLLVM_INSTALL_UTILS=ON -DCIRCT_SLANG_FRONTEND_ENABLED=ON
 # Optionally test
       - name: Test CIRCT
         if: inputs.run_tests

.github/workflows/unifiedBuildTestAndInstallStatic.yml

@@ -129,7 +129,7 @@ jobs:
         run: |
           mkdir -p build
           cd build
-          cmake -G Ninja -S "$(pwd)/../llvm/llvm" $EXTRA_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} -DLLVM_BUILD_TOOLS=ON -DLLVM_BUILD_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=${{ inputs.llvm_enable_assertions }} -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_EXTERNAL_PROJECTS=circt -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=".." -DLLVM_STATIC_LINK_CXX_STDLIB=ON -DLLVM_BUILD_STATIC=ON -DLLVM_LINK_LLVM_DYLIB=OFF -DLLVM_ENABLE_PIC=OFF -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_TARGETS_TO_BUILD="host" -DLLVM_FORCE_ENABLE_STATS=${{ inputs.llvm_force_enable_stats }} -DLLVM_ENABLE_ZSTD=OFF -DVERILATOR_DISABLE=ON -DCIRCT_RELEASE_TAG_ENABLED=ON -DCIRCT_RELEASE_TAG=firtool -DCMAKE_EXPORT_COMPILE_COMMANDS=OFF -DCMAKE_C_COMPILER=clang-19 -DCMAKE_CXX_COMPILER=clang++-19 ${{ steps.configure-sccache.outputs.enable_sccache }} -DCMAKE_INSTALL_PREFIX="$(pwd)/../install" -DLLVM_INSTALL_UTILS=ON -DCMAKE_EXE_LINKER_FLAGS_INIT="-Wl,-z,stack-size=8388608 -Wl,--whole-archive $(pwd)/../build/mimalloc/build/libmimalloc.a -Wl,--no-whole-archive"
+          cmake -G Ninja -S "$(pwd)/../llvm/llvm" $EXTRA_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} -DLLVM_BUILD_TOOLS=ON -DLLVM_BUILD_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=${{ inputs.llvm_enable_assertions }} -DLLVM_ENABLE_PROJECTS=mlir -DLLVM_EXTERNAL_PROJECTS=circt -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=".." -DLLVM_STATIC_LINK_CXX_STDLIB=ON -DLLVM_BUILD_STATIC=ON -DLLVM_LINK_LLVM_DYLIB=OFF -DLLVM_ENABLE_PIC=OFF -DLLVM_PARALLEL_LINK_JOBS=1 -DLLVM_TARGETS_TO_BUILD="host" -DLLVM_FORCE_ENABLE_STATS=${{ inputs.llvm_force_enable_stats }} -DLLVM_ENABLE_ZSTD=OFF -DVERILATOR_DISABLE=ON -DCIRCT_RELEASE_TAG_ENABLED=ON -DCIRCT_RELEASE_TAG=firtool -DCMAKE_EXPORT_COMPILE_COMMANDS=OFF -DCMAKE_C_COMPILER=clang-19 -DCMAKE_CXX_COMPILER=clang++-19 ${{ steps.configure-sccache.outputs.enable_sccache }} -DCMAKE_INSTALL_PREFIX="$(pwd)/../install" -DLLVM_INSTALL_UTILS=ON -DCIRCT_SLANG_FRONTEND_ENABLED=ON -DCMAKE_EXE_LINKER_FLAGS_INIT="-Wl,-z,stack-size=8388608 -Wl,--whole-archive $(pwd)/../build/mimalloc/build/libmimalloc.a -Wl,--no-whole-archive"
 # Optionally test
       - name: Test CIRCT
         if: inputs.run_tests

CMakeLists.txt

@@ -38,10 +38,6 @@ if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )
   # MSVC-specific compiler configuration
   if (MSVC)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHs-c- /GR-")
-    # Enable UTF-8 support for source files and string literals.  This is
-    # required by dependencies like fmt library.
-    string(APPEND CMAKE_CXX_FLAGS " /utf-8")
-    string(APPEND CMAKE_C_FLAGS " /utf-8")
   else ()
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-rtti")
   endif ()
@@ -569,9 +565,8 @@ if(CIRCT_SLANG_FRONTEND_ENABLED)
     FetchContent_Declare(
       slang
       GIT_REPOSITORY https://github.com/MikePopoloski/slang.git
-      GIT_TAG dd16a7947e0586d0541477f1b4b60eda7c986e35
-      # Shallow check-out doesn't work if the tag is ref spec is far from HEAD.
-      # GIT_SHALLOW ON
+      GIT_TAG v9.1
+      GIT_SHALLOW ON
     )
     set(FETCHCONTENT_TRY_FIND_PACKAGE_MODE "NEVER")
 
@@ -604,18 +599,19 @@ if(CIRCT_SLANG_FRONTEND_ENABLED)
         get_target_property(dep_target ${dep_alias} ALIASED_TARGET)
         message(STATUS "Installing slang dependency ${dep_target}")
         set_property(GLOBAL APPEND PROPERTY CIRCT_EXPORTS ${dep_target})
-        install(TARGETS ${dep_target} EXPORT CIRCTTargets)
 
         # Disable the installation of headers coming from third-party libraries.
         # We won't use those APIs directly. Just make them static libraries for
         # the sake of running slang normally.
         set_target_properties(${dep_target} PROPERTIES PUBLIC_HEADER "")
+
+        install(TARGETS ${dep_target} EXPORT CIRCTTargets)
       endif()
     endforeach()
     set_property(GLOBAL APPEND PROPERTY CIRCT_EXPORTS slang_slang)
     install(TARGETS slang_slang EXPORT CIRCTTargets)
   else()
-    find_package(slang 9.0 REQUIRED)
+    find_package(slang 9.1 REQUIRED)
   endif()
 endif()
 

README.md

@@ -54,7 +54,7 @@ For more information, please see our longer [charter document](docs/Charter.md).
 
 ## Getting Started
 
-To get started hacking on CIRCT quickly, run the following commands:
+To get started hacking on CIRCT quickly, run the following commands. If you want to include `circt-verilog` in the build, add `-DCIRCT_SLANG_FRONTEND_ENABLED=ON` to the cmake call:
 
 ```sh
 # Clone the repository and its submodules
@@ -69,14 +69,24 @@ cmake -G Ninja llvm/llvm -B build \
     -DLLVM_ENABLE_PROJECTS=mlir \
     -DLLVM_EXTERNAL_PROJECTS=circt \
     -DLLVM_EXTERNAL_CIRCT_SOURCE_DIR=$PWD
+    -DLLVM_ENABLE_LLD=ON
+```
 
-# Run the build
+If you want to build everything about the CIRCT tools and libraries, run below command(also runs all tests):
+```
 ninja -C build check-circt
 ```
 
-The above builds the CIRCT tools and libraries and runs all regression tests.
-If you want to include `circt-verilog` in the build, add `-DCIRCT_SLANG_FRONTEND_ENABLED=ON` to the cmake call.
-You can ask ninja to only build a specific library or tool, such as `ninja -C build circt-opt`.
+If you want to only build a specific part, for example the `circt-opt` tool:
+```sh
+ninja -C build bin/circt-opt
+```
+
+or the `firtool` tool:
+```sh
+ninja -C build bin/firtool
+```
+
 This will only build the necessary parts of LLVM, MLIR, and CIRCT, which can be a lot quicker than building everything.
 
 ### Dependencies