Skip to content

Commit 01afa4c

Browse files
[CI] Disable flaky Verilog LSP tests on macOS (#9293)
Disable the PendingChangesTest of the Verilog LSP on macOS. These tests tend to fail arbitrarily during the release artifact upload CI job, and rerunning the job will get them to pass. Tracking this in #9292.
1 parent 024df05 commit 01afa4c

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

unittests/Tools/circt-verilog-lsp-server/Utils/PendingChangesTest.cpp

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ makeChangeParams(llvm::StringRef memName, int64_t version,
6767

6868
/// Check that changes are done immediately if debounce is disabled
6969
TEST(PendingChangesMapTest, ImmediateFlushWhenDisabled) {
70+
#if defined(__APPLE__)
71+
// See https://github.com/llvm/circt/issues/9292.
72+
GTEST_SKIP() << "flaky on macOS";
73+
#endif
74+
7075
PendingChangesMap pcm(/*maxThreads=*/2);
7176
DebounceOptions opt;
7277
opt.disableDebounce = true;
@@ -89,6 +94,11 @@ TEST(PendingChangesMapTest, ImmediateFlushWhenDisabled) {
8994

9095
/// Check that changes are applied once debounce delay window is passed
9196
TEST(PendingChangesMapTest, FlushAfterQuietMinWindow) {
97+
#if defined(__APPLE__)
98+
// See https://github.com/llvm/circt/issues/9292.
99+
GTEST_SKIP() << "flaky on macOS";
100+
#endif
101+
92102
PendingChangesMap pcm(2);
93103
DebounceOptions opt;
94104
opt.disableDebounce = false;
@@ -115,6 +125,11 @@ TEST(PendingChangesMapTest, FlushAfterQuietMinWindow) {
115125

116126
/// Check that outdated edits are not applied and the thread is discarded.
117127
TEST(PendingChangesMapTest, ObsoleteWhenNewerEditsArrive) {
128+
#if defined(__APPLE__)
129+
// See https://github.com/llvm/circt/issues/9292.
130+
GTEST_SKIP() << "flaky on macOS";
131+
#endif
132+
118133
PendingChangesMap pcm(2);
119134
DebounceOptions opt;
120135
opt.disableDebounce = false;
@@ -153,6 +168,11 @@ TEST(PendingChangesMapTest, ObsoleteWhenNewerEditsArrive) {
153168
}
154169

155170
TEST(PendingChangesMapTest, MaxCapForcesFlushDuringContinuousTyping) {
171+
#if defined(__APPLE__)
172+
// See https://github.com/llvm/circt/issues/9292.
173+
GTEST_SKIP() << "flaky on macOS";
174+
#endif
175+
156176
PendingChangesMap pcm(2);
157177
DebounceOptions opt;
158178
opt.disableDebounce = false;
@@ -195,6 +215,11 @@ TEST(PendingChangesMapTest, MaxCapForcesFlushDuringContinuousTyping) {
195215

196216
/// Check that no update is queued if the change map is empty.
197217
TEST(PendingChangesMapTest, MissingKeyYieldsNullptr) {
218+
#if defined(__APPLE__)
219+
// See https://github.com/llvm/circt/issues/9292.
220+
GTEST_SKIP() << "flaky on macOS";
221+
#endif
222+
198223
PendingChangesMap pcm(2);
199224
DebounceOptions opt;
200225
opt.disableDebounce = false;
@@ -214,6 +239,11 @@ TEST(PendingChangesMapTest, MissingKeyYieldsNullptr) {
214239
}
215240

216241
TEST(PendingChangesMapTest, EraseByKeyAndUriAreIdempotent) {
242+
#if defined(__APPLE__)
243+
// See https://github.com/llvm/circt/issues/9292.
244+
GTEST_SKIP() << "flaky on macOS";
245+
#endif
246+
217247
PendingChangesMap pcm(/*maxThreads=*/2);
218248

219249
DebounceOptions opt;
@@ -267,6 +297,11 @@ TEST(PendingChangesMapTest, EraseByKeyAndUriAreIdempotent) {
267297
}
268298

269299
TEST(PendingChangesMapTest, AbortClearsAll) {
300+
#if defined(__APPLE__)
301+
// See https://github.com/llvm/circt/issues/9292.
302+
GTEST_SKIP() << "flaky on macOS";
303+
#endif
304+
270305
PendingChangesMap pcm(2);
271306

272307
// Debounced path to also cover the async branch

0 commit comments

Comments
 (0)