chore: remove run recovery notifications (#13883)

Remove the capability to trigger notifications including webhooks when a Forgejo Actions workflow run recovered. That functionality was added in https://codeberg.org/forgejo/forgejo/pulls/7509 but disabled in https://codeberg.org/forgejo/forgejo/pulls/8374 (Forgejo 12) because [it compared unrelated workflow runs](https://codeberg.org/forgejo/forgejo/issues/8373). It has never been repaired.

According to https://codeberg.org/forgejo/user-research/issues/63, interest for that capability is somewhere between inexistent and low. It is also not easy to express what "recovered" is supposed to mean when automatic cancellation and run reordering comes into play.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13883
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>

Author: aahlenst

models/actions/run.go

@@ -483,12 +483,6 @@ func GetLatestRun(ctx context.Context, repoID int64) (*ActionRun, error) {
 	return &run, nil
 }
 
-func GetRunBefore(ctx context.Context, _ *ActionRun) (*ActionRun, error) {
-	// TODO return the most recent run related to the run given in argument
-	// see https://codeberg.org/forgejo/user-research/issues/63 for context
-	return nil, util.ErrNotExist
-}
-
 func GetLatestRunForBranchAndWorkflow(ctx context.Context, repoID int64, branch, workflowFile, event string) (*ActionRun, error) {
 	var run ActionRun
 	q := db.GetEngine(ctx).Where("repo_id=?", repoID).And("workflow_id=?", workflowFile)

models/webhook/webhook.go

@@ -304,12 +304,6 @@ func (w *Webhook) HasActionRunFailureEvent() bool {
 		(w.ChooseEvents && w.ActionRunFailure)
 }
 
-// HasActionRunRecoverEvent returns if hook enabled action recover event.
-func (w *Webhook) HasActionRunRecoverEvent() bool {
-	return w.SendEverything ||
-		(w.ChooseEvents && w.ActionRunRecover)
-}
-
 // HasActionRunSuccessEvent returns if hook enabled action success event.
 func (w *Webhook) HasActionRunSuccessEvent() bool {
 	return w.SendEverything ||
@@ -355,7 +349,6 @@ func (w *Webhook) EventCheckers() []struct {
 		{w.HasPackageEvent, webhook_module.HookEventPackage},
 		{w.HasPullRequestReviewRequestEvent, webhook_module.HookEventPullRequestReviewRequest},
 		{w.HasActionRunFailureEvent, webhook_module.HookEventActionRunFailure},
-		{w.HasActionRunRecoverEvent, webhook_module.HookEventActionRunRecover},
 		{w.HasActionRunSuccessEvent, webhook_module.HookEventActionRunSuccess},
 	}
 }

models/webhook/webhook_test.go

@@ -74,8 +74,7 @@ func TestWebhook_EventsArray(t *testing.T) {
 		"pull_request", "pull_request_assign", "pull_request_label", "pull_request_milestone",
 		"pull_request_comment", "pull_request_review_approved", "pull_request_review_rejected",
 		"pull_request_review_comment", "pull_request_sync", "wiki", "repository", "release",
-		"package", "pull_request_review_request", "action_run_failure",
-		"action_run_recover", "action_run_success",
+		"package", "pull_request_review_request", "action_run_failure", "action_run_success",
 	},
 		(&Webhook{
 			HookEvent: &webhook_module.HookEvent{SendEverything: true},
@@ -157,7 +156,6 @@ func TestCreateWebhook(t *testing.T) {
 			// string(webhook_module.HookEventSchedule),
 			// string(webhook_module.HookEventWorkflowDispatch),
 			string(webhook_module.HookEventActionRunFailure),
-			string(webhook_module.HookEventActionRunRecover),
 			string(webhook_module.HookEventActionRunSuccess),
 		},
 			hookFromDb.EventsArray())

modules/structs/hook.go

@@ -508,9 +508,6 @@ type ActionPayload struct {
 	// the status of this run before it completed
 	// this must be a not done status
 	PriorStatus string `json:"prior_status"`
-	// the last run for the same workflow
-	// could be nil when Run is the first for it's workflow
-	LastRun *ActionRun `json:"last_run,omitempty"`
 }
 
 // JSONPayload return payload information

modules/webhook/structs.go

@@ -28,7 +28,6 @@ type HookEvents struct {
 	Release                  bool `json:"release"`
 	Package                  bool `json:"package"`
 	ActionRunFailure         bool `json:"action_run_failure"`
-	ActionRunRecover         bool `json:"action_run_recover"`
 	ActionRunSuccess         bool `json:"action_run_success"`
 }
 

modules/webhook/type.go

@@ -71,8 +71,6 @@ func (h HookEventType) Event() string {
 		return "release"
 	case HookEventActionRunFailure:
 		return "action_run_failure"
-	case HookEventActionRunRecover:
-		return "action_run_recover"
 	case HookEventActionRunSuccess:
 		return "action_run_success"
 	}

options/locale/locale_en-US.ini

@@ -2379,8 +2379,6 @@ settings.event_pull_request_enforcement = Enforcement
 settings.event_header_action = Action Run events
 settings.event_action_failure = Failure
 settings.event_action_failure_desc = Action Run ended as failure.
-settings.event_action_recover = Recover
-settings.event_action_recover_desc = Action Run succeeded after last Action Run in the same workflow failed.
 settings.event_action_success = Success
 settings.event_action_success_desc = Action Run succeeded.
 settings.event_package = Package

routers/api/v1/utils/hook.go

@@ -212,7 +212,6 @@ func addHook(ctx *context.APIContext, form *api.CreateHookOption, ownerID, repoI
 				Release:                  util.SliceContainsString(form.Events, string(webhook_module.HookEventRelease), true),
 				Package:                  util.SliceContainsString(form.Events, string(webhook_module.HookEventPackage), true),
 				ActionRunFailure:         util.SliceContainsString(form.Events, string(webhook_module.HookEventActionRunFailure), true),
-				ActionRunRecover:         util.SliceContainsString(form.Events, string(webhook_module.HookEventActionRunRecover), true),
 				ActionRunSuccess:         util.SliceContainsString(form.Events, string(webhook_module.HookEventActionRunSuccess), true),
 			},
 			BranchFilter: form.BranchFilter,

routers/api/v1/utils/hook_test.go

@@ -113,7 +113,6 @@ func TestHookEventInclusion(t *testing.T) {
 			string(webhook_module.HookEventRelease),
 			string(webhook_module.HookEventPackage),
 			string(webhook_module.HookEventActionRunFailure),
-			string(webhook_module.HookEventActionRunRecover),
 			string(webhook_module.HookEventActionRunSuccess),
 		},
 	}

routers/web/repo/setting/webhook.go

@@ -176,7 +176,6 @@ func ParseHookEvent(form forms.WebhookCoreForm) *webhook_module.HookEvent {
 			Repository:               form.Repository,
 			Package:                  form.Package,
 			ActionRunFailure:         form.ActionFailure,
-			ActionRunRecover:         form.ActionRecover,
 			ActionRunSuccess:         form.ActionSuccess,
 		},
 		BranchFilter: form.BranchFilter,