feat(perf): speedup available jobs query for user/org runner (#13666)

- The current query is not incorrect or has a inherent performance
  problem, but MariaDB choses a very wrong query plan for the
  `action_run_job`, `IDX_action_run_job_repo_id` over
  `IDX_action_run_job_status`. On surface level the former index looks
  like a good choice, for a organisation like Forgejo with many already
  executed jobs, it doesn't become a very effective index. The status
  index filters very well, because there aren't that many that have as
  status "waiting".
- Relevant: forgejo/forgejo!13658

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13666
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>

Author: Gusted

models/actions/task.go

@@ -313,8 +313,8 @@ func GetAvailableJobsForRunner(e db.Engine, runner *ActionRunner) ([]*ActionRunJ
 	if runner.RepoID != 0 {
 		jobCond = builder.Eq{"repo_id": runner.RepoID}
 	} else if runner.OwnerID != 0 {
-		jobCond = builder.In("repo_id", builder.Select("`repository`.id").From("repository").
-			Where(builder.Eq{"`repository`.owner_id": runner.OwnerID}))
+		jobCond = builder.Exists(builder.Select("`repository`.id").From("repository").
+			Where(builder.Expr("`repository`.owner_id = ? AND repo_id = `repository`.id", runner.OwnerID)))
 	}
 
 	// Concurrency group checks for queuing one run behind the last run in the concurrency group are more

tests/integration/actions_concurrency_group_queue_test.go

@@ -53,7 +53,8 @@ func TestActionConcurrencyRunnerFiltering(t *testing.T) {
 		},
 	} {
 		t.Run(tc.runnerName, func(t *testing.T) {
-			doTest := func() {
+			doTest := func(t *testing.T) {
+				t.Helper()
 				e := db.GetEngine(t.Context())
 
 				runner := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunner{Name: tc.runnerName})
@@ -68,13 +69,15 @@ func TestActionConcurrencyRunnerFiltering(t *testing.T) {
 			}
 
 			t.Run("ConcurrencyGroupQueueEnabled", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
 				defer test.MockVariableValue(&setting.Actions.ConcurrencyGroupQueueEnabled, true)()
-				doTest()
+				doTest(t)
 			})
 
 			t.Run("ConcurrencyGroupQueueDisabled", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
 				defer test.MockVariableValue(&setting.Actions.ConcurrencyGroupQueueEnabled, false)()
-				doTest()
+				doTest(t)
 			})
 		})
 	}