Skip to content

Commit 1e6c06b

Browse files
n0toose0ko
authored andcommitted
fix(ui): make repo lfs settings tables more flexible (#13885)
Most of the changes are intended to improve mobile-friendliness. - Remove erroneous `{{` (no impact) - Change "Accessible to user" string to "User-readable", as it is otherwise cut off an all platforms. - Copy most of the class names from authentication sources apart from 'striped'. - Remove unnecessary leftover 'attached' keyword. - Use same classes for both lfs.tmpl and lfs_pointer.tmpl tables. Screenshots (The change includes a minor cosmetic modification, but given that it just took up more space and was [called ugly](https://codeberg.org/forgejo/forgejo/pulls/12960#issuecomment-20561813), I hope that this won't be controversial. The screenshots shown below will include "portrait mode" screenshots.) ### Before https://codeberg.org/attachments/33765110-f426-4cc9-b53b-83e1bd146ead https://codeberg.org/attachments/6d49743d-3500-447b-9352-6feb02a9f3dc https://codeberg.org/attachments/e79558cb-16a7-4378-b6fe-c13b9d9dde13 ### After https://codeberg.org/attachments/349f2cc9-c66a-4e52-8b1b-c9cd09053eea https://codeberg.org/attachments/7dca04c4-733d-445a-9ad5-eb840d60b391 https://codeberg.org/attachments/fdb5f545-7efb-4911-80ce-8b9cb22a6196 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13885 Reviewed-by: 0ko <0ko@noreply.codeberg.org>
1 parent c8bb407 commit 1e6c06b

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

options/locale/locale_en-US.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2563,7 +2563,7 @@ settings.lfs_pointers.sha = Blob hash
25632563
settings.lfs_pointers.oid = OID
25642564
settings.lfs_pointers.inRepo = In repo
25652565
settings.lfs_pointers.exists = Exists in store
2566-
settings.lfs_pointers.accessible = Accessible to user
2566+
settings.lfs_pointers.accessible = User-accessible
25672567
settings.lfs_pointers.associateAccessible = Associate accessible %d OIDs
25682568
settings.rename_branch_failed_protected = Cannot rename branch %s because it is a protected branch.
25692569
settings.rename_branch_failed_exist = Cannot rename branch because target branch %s exists.

templates/repo/settings/lfs.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
</h4>
1111
</div>
1212
<div class="ui attached segment">
13-
<table id="lfs-files-table" class="ui attached segment single line table">
13+
<table id="lfs-files-table" class="ui very basic table unstackable">
1414
<thead>
1515
<tr>
16-
<th class="four wide"}}>{{ctx.Locale.Tr "repo.settings.lfs_pointers.oid"}}</th>
16+
<th class="four wide">{{ctx.Locale.Tr "repo.settings.lfs_pointers.oid"}}</th>
1717
<th class="two wide" data-tooltip-content="{{ctx.Locale.Tr "repo.settings.lfs.size"}}">{{ctx.Locale.Tr "repo.settings.lfs.size"}}</th>
1818
<th class="two wide" data-tooltip-content="{{ctx.Locale.Tr "repo.settings.lfs.last_update"}}">{{ctx.Locale.Tr "repo.settings.lfs.last_update"}}</th>
1919
<th class="three wide"></th>

templates/repo/settings/lfs_pointers.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{{end}}
1717
</h4>
1818
<div class="ui attached segment">
19-
<table id="lfs-files-table" class="ui fixed single line table">
19+
<table id="lfs-files-table" class="ui very basic table unstackable">
2020
<thead>
2121
<tr>
2222
<th class="three wide">{{ctx.Locale.Tr "repo.settings.lfs_pointers.sha"}}</th>

0 commit comments

Comments
 (0)