Skip to content

Commit 1a4c5cd

Browse files
limiting-factorGusted
authored andcommitted
fix: pin github.com/urfave/cli to v3.5.0 (#10828)
Upgrading to v3.6.1 breaks `--help` ``` $ forgejo forgejo-cli --help Incorrect Usage: flag provided but not defined: -help ``` ### Testing ``` $ make forgejo $ ./forgejo forgejo-cli --help NAME: forgejo forgejo-cli - Forgejo CLI USAGE: forgejo forgejo-cli [command [command options]] COMMANDS: actions Commands for managing Forgejo Actions f3 F3 ``` Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10828 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Michael Kriese <michael.kriese@gmx.de> Co-authored-by: limiting-factor <limiting-factor@posteo.com> Co-committed-by: limiting-factor <limiting-factor@posteo.com>
1 parent 635d550 commit 1a4c5cd

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

cmd/main_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,11 @@ func TestCliCmd(t *testing.T) {
108108
cmd: "./gitea test-cmd --config /tmp/app-other.ini",
109109
exp: makePathOutput("/tmp", "/tmp/custom", "/tmp/app-other.ini"),
110110
},
111+
{
112+
env: map[string]string{"GITEA_WORK_DIR": "/tmp"},
113+
cmd: "./gitea forgejo-cli --help",
114+
exp: "(subcommand help template)",
115+
},
111116
}
112117

113118
for _, c := range cases {

go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,3 +274,5 @@ replace github.com/gliderlabs/ssh => code.forgejo.org/forgejo/ssh v0.0.0-2024121
274274
replace git.sr.ht/~mariusor/go-xsd-duration => code.forgejo.org/forgejo/go-xsd-duration v0.0.0-20220703122237-02e73435a078
275275

276276
replace xorm.io/xorm v1.3.9 => code.forgejo.org/xorm/xorm v1.3.9-forgejo.4
277+
278+
replace github.com/urfave/cli/v3 => github.com/urfave/cli/v3 v3.5.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,8 @@ github.com/tinylib/msgp v1.3.0/go.mod h1:ykjzy2wzgrlvpDCRc4LA8UXy6D8bzMSuAF3WD57
660660
github.com/ulikunitz/xz v0.5.8/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
661661
github.com/ulikunitz/xz v0.5.15 h1:9DNdB5s+SgV3bQ2ApL10xRc35ck0DuIX/isZvIk+ubY=
662662
github.com/ulikunitz/xz v0.5.15/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
663-
github.com/urfave/cli/v3 v3.6.1 h1:j8Qq8NyUawj/7rTYdBGrxcH7A/j7/G8Q5LhWEW4G3Mo=
664-
github.com/urfave/cli/v3 v3.6.1/go.mod h1:ysVLtOEmg2tOy6PknnYVhDoouyC/6N42TMeoMzskhso=
663+
github.com/urfave/cli/v3 v3.5.0 h1:qCuFMmdayTF3zmjG8TSsoBzrDqszNrklYg2x3g4MSgw=
664+
github.com/urfave/cli/v3 v3.5.0/go.mod h1:ysVLtOEmg2tOy6PknnYVhDoouyC/6N42TMeoMzskhso=
665665
github.com/valyala/fastjson v1.6.4/go.mod h1:CLCAqky6SMuOcxStkYQvblddUtoRxhYMGLrsQns1aXY=
666666
github.com/valyala/fastjson v1.6.7 h1:ZE4tRy0CIkh+qDc5McjatheGX2czdn8slQjomexVpBM=
667667
github.com/valyala/fastjson v1.6.7/go.mod h1:CLCAqky6SMuOcxStkYQvblddUtoRxhYMGLrsQns1aXY=

0 commit comments

Comments
 (0)