Skip to content

Commit 158a449

Browse files
drewcassidyGusted
authored andcommitted
chore: use correct value to disable timeouts in example config (#12985)
These values are parsed as durations, and rejected if they encounter parsing errors. "-1" lacks a unit, and is rejected. The end result is that setting PER_WRITE_TIMEOUT = -1 just uses the default 30s See also forgejo/docs!2005 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12985 Reviewed-by: Gusted <gusted@noreply.codeberg.org>
1 parent c513dba commit 158a449

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

custom/conf/app.example.ini

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ RUN_USER = ; git
118118
;; SSL Cipher Suites
119119
;SSL_CIPHER_SUITES=; Will default to "ecdhe_ecdsa_with_aes_256_gcm_sha384,ecdhe_rsa_with_aes_256_gcm_sha384,ecdhe_ecdsa_with_aes_128_gcm_sha256,ecdhe_rsa_with_aes_128_gcm_sha256,ecdhe_ecdsa_with_chacha20_poly1305,ecdhe_rsa_with_chacha20_poly1305" if aes is supported by hardware, otherwise chacha will be first.
120120
;;
121-
;; Timeout for any write to the connection. (Set to -1 to disable all timeouts.)
121+
;; Timeout for any write to the connection. (Set to -1s to disable all timeouts.)
122122
;PER_WRITE_TIMEOUT = 30s
123123
;;
124124
;; Timeout per Kb written to connections.
@@ -232,7 +232,7 @@ RUN_USER = ; git
232232
;; Command template for authorized keys entries
233233
;SSH_AUTHORIZED_KEYS_COMMAND_TEMPLATE = {{.AppPath}} --config={{.CustomConf}} serv key-{{.Key.ID}}
234234
;;
235-
;; Timeout for any write to ssh connections. (Set to -1 to disable all timeouts.)
235+
;; Timeout for any write to ssh connections. (Set to -1s to disable all timeouts.)
236236
;; Will default to the PER_WRITE_TIMEOUT.
237237
;SSH_PER_WRITE_TIMEOUT = 30s
238238
;;
@@ -1378,7 +1378,7 @@ LEVEL = Info
13781378
;;
13791379
;; Control how often the notification endpoint is polled to update the notification
13801380
;; The timeout will increase to MAX_TIMEOUT in TIMEOUT_STEPs if the notification count is unchanged
1381-
;; Set MIN_TIMEOUT to -1 to turn off
1381+
;; Set MIN_TIMEOUT to -1s to turn off polling
13821382
;MIN_TIMEOUT = 10s
13831383
;MAX_TIMEOUT = 60s
13841384
;TIMEOUT_STEP = 10s
@@ -1470,7 +1470,7 @@ LEVEL = Info
14701470
;ISSUE_INDEXER_NAME = gitea_issues
14711471
;;
14721472
;; Timeout the indexer if it takes longer than this to start.
1473-
;; Set to -1 to disable timeout.
1473+
;; Set to -1s to disable timeout.
14741474
;STARTUP_TIMEOUT = 30s
14751475
;;
14761476
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

0 commit comments

Comments
 (0)