Skip to content

Commit 1043c67

Browse files
nigorollMathieu Fenniak
authored andcommitted
Skip sha256 repo tests if sha256 not supported (#13018)
Otherwise the newly introduced test from #12335 fails on platforms which do not have git sha256 yet ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [X] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [X] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [X] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [X] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13018 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
1 parent bb5919e commit 1043c67

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

modules/git/repo_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,11 @@ func TestInitRepositoryWithNoTemplates(t *testing.T) {
148148
}
149149
for _, tt := range tests {
150150
t.Run(tt.name, func(t *testing.T) {
151+
if !IsValidObjectFormat(tt.objectFormatName) {
152+
t.Skip("not supported")
153+
return
154+
}
155+
151156
repoPath := t.TempDir()
152157

153158
err := InitRepository(t.Context(), repoPath, tt.bare, tt.objectFormatName)

0 commit comments

Comments
 (0)