Skip to content
This repository was archived by the owner on Oct 17, 2020. It is now read-only.

Commit f853c40

Browse files
committed
chore: #518 Don't fail check-deps for snapshot versions
This is needed to be able to release snapshots.
1 parent 838a6ec commit f853c40

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

scripts/check-deps.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
* SPDX-License-Identifier: LGPL-3.0-or-later
44
*/
55

6-
const getDepVersions = require('./util/get-dep-versions');
6+
const {
7+
coalesceSnapshotVersions,
8+
getDepVersions,
9+
} = require('./util/get-dep-versions');
710

811
const depVersions = getDepVersions();
912
let mismatchsFound = false;
1013

1114
Object.entries(depVersions).forEach(([pkg, versions]) => {
15+
versions = coalesceSnapshotVersions(versions);
16+
1217
if (Object.keys(versions).length > 1) {
1318
mismatchsFound = true;
1419

scripts/util/get-dep-versions.js

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,26 @@
66
const fs = require('fs');
77
const globby = require('globby');
88

9+
function coalesceSnapshotVersions(versions) {
10+
let coalescedVersions = {};
11+
12+
Object.keys(versions).forEach(version => {
13+
const i = version.indexOf('-snapshot.');
14+
15+
if (i != -1) {
16+
const refVersion = version.substring(0, i);
17+
18+
coalescedVersions[refVersion] = coalescedVersions[refVersion] || [];
19+
coalescedVersions[refVersion].push(...versions[version]);
20+
} else {
21+
coalescedVersions[version] = coalescedVersions[version] || [];
22+
coalescedVersions[version].push(...versions[version]);
23+
}
24+
});
25+
26+
return coalescedVersions;
27+
}
28+
929
function getDepVersions() {
1030
const filePaths = globby.sync(['packages/*/package.json']);
1131

@@ -32,4 +52,7 @@ function getDepVersions() {
3252
return depVersions;
3353
}
3454

35-
module.exports = getDepVersions;
55+
module.exports = {
56+
coalesceSnapshotVersions,
57+
getDepVersions,
58+
};

0 commit comments

Comments
 (0)