Skip to content

Commit 5ae4f29

Browse files
committed
chore: address review
1 parent 79d2852 commit 5ae4f29

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/dialer/index.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ const {
1818
MAX_PER_PEER_DIALS
1919
} = require('../constants')
2020

21-
const dns4Code = 54
22-
const dns6Code = 55
23-
2421
class Dialer {
2522
/**
2623
* @class
@@ -45,9 +42,12 @@ class Dialer {
4542
this.concurrency = concurrency
4643
this.timeout = timeout
4744
this.perPeerLimit = perPeerLimit
48-
this.resolvers = resolvers
4945
this.tokens = [...new Array(concurrency)].map((_, index) => index)
5046
this._pendingDials = new Map()
47+
48+
for (const [key, value] of Object.entries(resolvers)) {
49+
multiaddr.resolvers.set(key, value)
50+
}
5151
}
5252

5353
/**
@@ -211,10 +211,11 @@ class Dialer {
211211
*/
212212
async _resolve (ma) {
213213
// TODO: recursive logic should live in multiaddr once dns4/dns6 support is in place
214-
const resolvableProto = ma.protos().find((p) => p.resolvable)
214+
// Now only supporting resolve for dnsaddr
215+
const resolvableProto = ma.protoNames().includes('dnsaddr')
215216

216217
// Multiaddr is not resolvable (including exception for dns4/dns6)? End recursion!
217-
if (!resolvableProto || resolvableProto.code === dns4Code || resolvableProto === dns6Code) {
218+
if (!resolvableProto) {
218219
return [ma]
219220
}
220221

@@ -238,10 +239,6 @@ class Dialer {
238239
* @returns {Promise<Array<Multiaddr>>}
239240
*/
240241
_resolveRecord (ma) {
241-
for (const [key, value] of Object.entries(this.resolvers)) {
242-
ma.resolvers.set(key, value)
243-
}
244-
245242
return ma.resolve()
246243
}
247244
}

0 commit comments

Comments
 (0)