This repository was archived by the owner on Mar 11, 2020. It is now read-only.
feat: add support for timeline proxying #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Libp2p we need to know when a connection has closed, as it allows us to do a variety of clean up tasks, notifications, etc. Rather than passing additional handlers to be able to know when the connection has closed, this simply removes the
stat.timelinedestructuring in the constructor to allow Proxies to work properly. As shown in the tests, this enables us to create custom handlers when certain properties change, namelytimeline.close. When the value is set by theMultiaddrConnection, we can perform any actions the rest of the system needs.