fix lints

Author: oowekyala

benches/savina_pong.rs

@@ -453,7 +453,7 @@ mod reactors {
         impl ::reactor_rt::assembly::ReactorInitializer for SavinaPongAdapter {
             type Wrapped = SavinaPong;
             type Params = SavinaPongParams;
-            const MAX_REACTION_ID: ::reactor_rt::LocalReactionId = ::reactor_rt::LocalReactionId::new(1 - 1);
+            const MAX_REACTION_ID: ::reactor_rt::LocalReactionId = ::reactor_rt::LocalReactionId::new(0);
 
             fn assemble(
                 __params: Self::Params,

src/actions.rs

@@ -116,7 +116,7 @@ impl<T: Sync, K> ReactionTrigger<T> for Action<K, T> {
 #[cfg(not(feature = "no-unsafe"))]
 impl<T: Sync, K> triggers::ReactionTriggerWithRefAccess<T> for Action<K, T> {
     fn get_value_ref(&self, now: &EventTag, _start: &Instant) -> Option<&T> {
-        self.map.get(&Reverse(*now)).map(|a| a.as_ref()).flatten()
+        self.map.get(&Reverse(*now)).and_then(|a| a.as_ref())
     }
 }
 

src/lib.rs

@@ -61,8 +61,8 @@
 #[macro_use]
 extern crate array_macro;
 #[cfg(test)]
-#[macro_use]
 #[allow(unused)]
+#[macro_use]
 extern crate assert_matches;
 #[macro_use]
 extern crate index_vec;
@@ -94,12 +94,12 @@ pub use self::util::*;
 pub mod test;
 
 mod actions;
-pub(self) mod ids;
+mod ids;
 mod ports;
 mod scheduler;
 mod time;
 mod timers;
-pub(self) mod triggers;
+mod triggers;
 mod util;
 
 pub mod assembly;

src/scheduler/dependencies.rs

@@ -776,7 +776,7 @@ pub mod test {
 
         fn new_ports<const N: usize>(&mut self, names: [&'static str; N]) -> [TriggerId; N] {
             let result = array![_ => self.fixture.next_trigger_id.get_and_incr().unwrap(); N];
-            for (i, p) in (&result).iter().enumerate() {
+            for (i, p) in result.iter().enumerate() {
                 self.fixture.graph.record_port(*p);
                 self.fixture.debug_info.record_trigger(*p, Cow::Borrowed(names[i]));
             }

src/scheduler/mod.rs

@@ -45,13 +45,13 @@ pub mod internals {
     pub use super::dependencies::{ExecutableReactions, Level, LevelIx, ReactionLevelInfo};
 }
 
-pub(self) type ReactionPlan<'x> = Option<Cow<'x, ExecutableReactions<'x>>>;
-pub(self) type ReactorBox<'a> = Box<dyn ReactorBehavior + 'a>;
-pub(self) type ReactorVec<'a> = IndexVec<ReactorId, ReactorBox<'a>>;
+type ReactionPlan<'x> = Option<Cow<'x, ExecutableReactions<'x>>>;
+type ReactorBox<'a> = Box<dyn ReactorBehavior + 'a>;
+type ReactorVec<'a> = IndexVec<ReactorId, ReactorBox<'a>>;
 
 /// Can format stuff for trace messages.
 #[derive(Clone)]
-pub(self) struct DebugInfoProvider<'a> {
+struct DebugInfoProvider<'a> {
     id_registry: &'a DebugInfoRegistry,
 }