Merged
Conversation
Sources/LaunchDarklySessionReplay/Exporter/SessionReplayEventGenerator.swift
Show resolved
Hide resolved
Sources/LaunchDarklySessionReplay/Exporter/IdentifyItemPayload.swift
Outdated
Show resolved
Hide resolved
Sources/LaunchDarklySessionReplay/Exporter/IdentifyItemPayload.swift
Outdated
Show resolved
Hide resolved
mario-launchdarkly
approved these changes
Dec 11, 2025
| withSpans: true, | ||
| withValue: true, | ||
| version: options.serviceVersion, | ||
| options: options)] |
There was a problem hiding this comment.
Bug: Hook receives stale options without SDK metadata
The getHooks method passes self.options (the original immutable options) to ObservabilityHook, but Options is a struct. In register, line 19 creates a local copy with var options = options, modifies it with SDK metadata (version, project ID, service name, etc.), and uses that copy for ObservabilityClientFactory.instantiate. However, the modified copy is discarded when register returns. The hook's beforeEvaluation method uses options.resourceAttributes which will be missing all the SDK metadata that was added in register.
Additional Locations (1)
abelonogov-ld
pushed a commit
that referenced
this pull request
Dec 12, 2025
🤖 I have created a release *beep* *boop* --- ## [0.13.0](0.12.1...0.13.0) (2025-12-12) ### Features * Identify support (OBS + SR) ([#93](#93)) ([432f75c](432f75c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 0.13.0 introducing Identify support, with version bumps across podspecs/manifest and sdkVersion update. > > - **Release 0.13.0** > - CHANGELOG: add feature entry for Identify support (OBS + SR) in `CHANGELOG.md`. > - Version bumps: `s.version` in `LaunchDarklyObservability.podspec` and `LaunchDarklySessionReplay.podspec` to `0.13.0`; `sdkVersion` in `Sources/LaunchDarklyObservability/Version.swift` to `0.13.0`. > - Manifest: update `.` to `0.13.0` in `.release-please-manifest.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9778dec. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
abelonogov-ld
added a commit
that referenced
this pull request
Jan 12, 2026
* main: (38 commits) chore(main): release 0.15.2 (#113) fix: make unlock await aware (#111) Fix SwiftUI hits stealing attempt 2 (#112) chore(main): release 0.15.1 (#110) fix: ldMask interfere with hit view testing (#108) chore(main): release 0.15.0 (#106) feat: Deduplicate images before buffering (#107) feat: Gzip compression of graphql request (#105) chore(main): release 0.14.0 (#103) feat: Flush buffers on going to app switcher (#104) fix: UIDevice.current.orientation.isLandscape not main thread access (#102) feat: Limit accumulating canvas buffer (#101) chore: remove disableErrorTracking option (#99) chore: remove unused options in observability plugin (#98) chore(main): release 0.13.1 (#97) fix: Rewrite AppLifeCycleManager onto Combine (#95) chore(main): release 0.13.0 (#96) feat: Identify support (OBS + SR) (#93) chore: Objective-c recordLog (#94) chore(main): release 0.12.1 (#91) ... # Conflicts: # Package.swift # Sources/LaunchDarklyObservability/Plugin/ObservabilityHook.swift # Sources/LaunchDarklyObservability/UIInteractions/TouchIntepreter.swift # Sources/Observability/Client/ObservabilityClientFactory.swift # Sources/OpenTelemetry/Instrumentation/URLSession/URLSessionLogger.swift # TestApp/Sources/AppDelegate.swift # TestApp/Sources/MainMenuView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds Identify lifecycle hooks to Observability and Session Replay, propagating user/canonical keys (with optional friendly name) to logs and SR events, plus refactors and an SDK bump.
Options.contextFriendlyNameused when recording Identify.InternalObserveexposinglogClient;Observabilitystores created service.EvalTracingHookwithObservabilityHook; logsLD.identifyafter Identify with attributeskey,canonicalKey, andidentify.result.status.IdentifyItemPayload(encodes context into attributes) and replace screen payload withImageItemPayload.SessionReplayEventGeneratoremitsCustomevent with tagIdentify; addsReloadpayload title from app name.SessionReplayExporteridentifies sessions using user attributes (on init and on-demand); stores pending Identify payload.SessionReplayServicewiresObservabilityContext, app title (ApplicationProperties.name), and schedules Identify via newSessionReplayHook(after Identify).CustomDataTag.identifydeserialization.ApplicationProperties.name(readsCFBundleName).ios-client-sdkto10.1.0.MainMenuView+MainMenuViewModel; add Identify actions (user/multi/anon); setOptions.contextFriendlyNamein config.Written by Cursor Bugbot for commit 5e20650. This will update automatically on new commits. Configure here.