Skip to content

[11.x] Get authenticated user from the guard #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Http/Controllers/AuthorizationController.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function authorize(ServerRequestInterface $psrRequest,
$request->session()->forget('promptedForLogin');

$scopes = $this->parseScopes($authRequest);
$user = $request->user();
$user = $this->guard->user();
$client = $clients->find($authRequest->getClient()->getIdentifier());

if ($request->get('prompt') !== 'consent' &&
Expand Down Expand Up @@ -137,7 +137,7 @@ protected function parseScopes($authRequest)
* Determine if a valid token exists for the given user, client, and scopes.
*
* @param \Laravel\Passport\TokenRepository $tokens
* @param \Illuminate\Database\Eloquent\Model $user
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @param \Laravel\Passport\Client $client
* @param array $scopes
* @return bool
Expand All @@ -153,7 +153,7 @@ protected function hasValidToken($tokens, $user, $client, $scopes)
* Approve the authorization request.
*
* @param \League\OAuth2\Server\RequestTypes\AuthorizationRequest $authRequest
* @param \Illuminate\Database\Eloquent\Model $user
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @return \Illuminate\Http\Response
*/
protected function approveRequest($authRequest, $user)
Expand All @@ -173,7 +173,7 @@ protected function approveRequest($authRequest, $user)
* Deny the authorization request.
*
* @param \League\OAuth2\Server\RequestTypes\AuthorizationRequest $authRequest
* @param \Illuminate\Database\Eloquent\Model|null $user
* @param \Illuminate\Contracts\Auth\Authenticatable|null $user
* @return \Illuminate\Http\Response
*/
protected function denyRequest($authRequest, $user = null)
Expand Down
4 changes: 2 additions & 2 deletions src/TokenRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function forUser($userId)
/**
* Get a valid token instance for the given user and client.
*
* @param \Illuminate\Database\Eloquent\Model $user
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @param \Laravel\Passport\Client $client
* @return \Laravel\Passport\Token|null
*/
Expand Down Expand Up @@ -107,7 +107,7 @@ public function isAccessTokenRevoked($id)
/**
* Find a valid token for the given user and client.
*
* @param \Illuminate\Database\Eloquent\Model $user
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @param \Laravel\Passport\Client $client
* @return \Laravel\Passport\Token|null
*/
Expand Down
10 changes: 5 additions & 5 deletions tests/Unit/AuthorizationControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ public function test_authorization_view_is_presented()
$controller = new AuthorizationController($server, $response, $guard);

$guard->shouldReceive('guest')->andReturn(false);
$guard->shouldReceive('user')->andReturn($user = m::mock());
$server->shouldReceive('validateAuthorizationRequest')->andReturn($authRequest = m::mock());

$request = m::mock(Request::class);
$request->shouldReceive('session')->andReturn($session = m::mock());
$session->shouldReceive('put')->withSomeOfArgs('authToken');
$session->shouldReceive('put')->with('authRequest', $authRequest);
$session->shouldReceive('forget')->with('promptedForLogin')->once();
$request->shouldReceive('user')->andReturn($user = m::mock());
$request->shouldReceive('get')->with('prompt')->andReturn(null);

$authRequest->shouldReceive('getClient->getIdentifier')->andReturn(1);
Expand Down Expand Up @@ -114,6 +114,7 @@ public function test_request_is_approved_if_valid_token_exists()
$controller = new AuthorizationController($server, $response, $guard);

$guard->shouldReceive('guest')->andReturn(false);
$guard->shouldReceive('user')->andReturn($user = m::mock());
$psrResponse = new Response();
$psrResponse->getBody()->write('approved');
$server->shouldReceive('validateAuthorizationRequest')
Expand All @@ -125,7 +126,6 @@ public function test_request_is_approved_if_valid_token_exists()
$request = m::mock(Request::class);
$request->shouldReceive('session')->andReturn($session = m::mock());
$session->shouldReceive('forget')->with('promptedForLogin')->once();
$request->shouldReceive('user')->once()->andReturn($user = m::mock());
$user->shouldReceive('getAuthIdentifier')->andReturn(1);
$request->shouldNotReceive('session');
$request->shouldReceive('get')->with('prompt')->andReturn(null);
Expand Down Expand Up @@ -164,6 +164,7 @@ public function test_request_is_approved_if_client_can_skip_authorization()
$controller = new AuthorizationController($server, $response, $guard);

$guard->shouldReceive('guest')->andReturn(false);
$guard->shouldReceive('user')->andReturn($user = m::mock());
$psrResponse = new Response();
$psrResponse->getBody()->write('approved');
$server->shouldReceive('validateAuthorizationRequest')
Expand All @@ -175,7 +176,6 @@ public function test_request_is_approved_if_client_can_skip_authorization()
$request = m::mock(Request::class);
$request->shouldReceive('session')->andReturn($session = m::mock());
$session->shouldReceive('forget')->with('promptedForLogin')->once();
$request->shouldReceive('user')->once()->andReturn($user = m::mock());
$user->shouldReceive('getAuthIdentifier')->andReturn(1);
$request->shouldNotReceive('session');
$request->shouldReceive('get')->with('prompt')->andReturn(null);
Expand Down Expand Up @@ -213,6 +213,7 @@ public function test_authorization_view_is_presented_if_request_has_prompt_equal
$controller = new AuthorizationController($server, $response, $guard);

$guard->shouldReceive('guest')->andReturn(false);
$guard->shouldReceive('user')->andReturn($user = m::mock());
$server->shouldReceive('validateAuthorizationRequest')
->andReturn($authRequest = m::mock(AuthorizationRequest::class));

Expand All @@ -221,7 +222,6 @@ public function test_authorization_view_is_presented_if_request_has_prompt_equal
$session->shouldReceive('put')->withSomeOfArgs('authToken');
$session->shouldReceive('put')->with('authRequest', $authRequest);
$session->shouldReceive('forget')->with('promptedForLogin')->once();
$request->shouldReceive('user')->andReturn($user = m::mock());
$request->shouldReceive('get')->with('prompt')->andReturn('consent');

$authRequest->shouldReceive('getClient->getIdentifier')->once()->andReturn(1);
Expand Down Expand Up @@ -263,6 +263,7 @@ public function test_authorization_denied_if_request_has_prompt_equals_to_none()
$controller = new AuthorizationController($server, $response, $guard);

$guard->shouldReceive('guest')->andReturn(false);
$guard->shouldReceive('user')->andReturn($user = m::mock());
$server->shouldReceive('validateAuthorizationRequest')
->andReturn($authRequest = m::mock(AuthorizationRequest::class));
$server->shouldReceive('completeAuthorizationRequest')
Expand All @@ -273,7 +274,6 @@ public function test_authorization_denied_if_request_has_prompt_equals_to_none()
$request = m::mock(Request::class);
$request->shouldReceive('session')->andReturn($session = m::mock());
$session->shouldReceive('forget')->with('promptedForLogin')->once();
$request->shouldReceive('user')->andReturn($user = m::mock());
$user->shouldReceive('getAuthIdentifier')->andReturn(1);
$request->shouldReceive('get')->with('prompt')->andReturn('none');

Expand Down