From b9dfd91f48e65b7c8346037f7a4b31a80791d7f8 Mon Sep 17 00:00:00 2001
From: Hafez Divandari <hafezdivandari@gmail.com>
Date: Sat, 3 Sep 2022 14:56:19 +0430
Subject: [PATCH] Support disabling prompt when redirecting for authorization

---
 .../Controllers/AuthorizationController.php   | 24 +++++++++++
 tests/Unit/AuthorizationControllerTest.php    | 43 +++++++++++++++++++
 2 files changed, 67 insertions(+)

diff --git a/src/Http/Controllers/AuthorizationController.php b/src/Http/Controllers/AuthorizationController.php
index 5eb2d5db8..09e561bc0 100644
--- a/src/Http/Controllers/AuthorizationController.php
+++ b/src/Http/Controllers/AuthorizationController.php
@@ -71,6 +71,10 @@ public function authorize(ServerRequestInterface $psrRequest,
             return $this->approveRequest($authRequest, $user);
         }
 
+        if ($request->get('prompt') === 'none') {
+            return $this->denyRequest($authRequest, $user);
+        }
+
         $request->session()->put('authToken', $authToken = Str::random());
         $request->session()->put('authRequest', $authRequest);
 
@@ -133,4 +137,24 @@ protected function approveRequest($authRequest, $user)
             );
         });
     }
+
+    /**
+     * Deny the authorization request.
+     *
+     * @param  \League\OAuth2\Server\RequestTypes\AuthorizationRequest  $authRequest
+     * @param  \Illuminate\Database\Eloquent\Model  $user
+     * @return \Illuminate\Http\Response
+     */
+    protected function denyRequest($authRequest, $user)
+    {
+        $authRequest->setUser(new User($user->getAuthIdentifier()));
+
+        $authRequest->setAuthorizationApproved(false);
+
+        return $this->withErrorHandling(function () use ($authRequest) {
+            return $this->convertResponse(
+                $this->server->completeAuthorizationRequest($authRequest, new Psr7Response)
+            );
+        });
+    }
 }
diff --git a/tests/Unit/AuthorizationControllerTest.php b/tests/Unit/AuthorizationControllerTest.php
index 8631e06df..f91483431 100644
--- a/tests/Unit/AuthorizationControllerTest.php
+++ b/tests/Unit/AuthorizationControllerTest.php
@@ -227,4 +227,47 @@ public function test_authorization_view_is_presented_if_request_has_prompt_equal
             m::mock(ServerRequestInterface::class), $request, $clients, $tokens
         ));
     }
+
+    public function test_authorization_denied_if_request_has_prompt_equals_to_none()
+    {
+        $this->expectException('Laravel\Passport\Exceptions\OAuthServerException');
+
+        Passport::tokensCan([
+            'scope-1' => 'description',
+        ]);
+
+        $server = m::mock(AuthorizationServer::class);
+        $response = m::mock(ResponseFactory::class);
+
+        $controller = new AuthorizationController($server, $response);
+        $server->shouldReceive('validateAuthorizationRequest')
+            ->andReturn($authRequest = m::mock(AuthorizationRequest::class));
+        $server->shouldReceive('completeAuthorizationRequest')
+            ->with($authRequest, m::type(ResponseInterface::class))
+            ->once()
+            ->andThrow('League\OAuth2\Server\Exception\OAuthServerException');
+
+        $request = m::mock(Request::class);
+        $request->shouldReceive('user')->andReturn($user = m::mock());
+        $user->shouldReceive('getAuthIdentifier')->andReturn(1);
+        $request->shouldReceive('get')->with('prompt')->andReturn('none');
+
+        $authRequest->shouldReceive('getClient->getIdentifier')->once()->andReturn(1);
+        $authRequest->shouldReceive('getScopes')->once()->andReturn([new Scope('scope-1')]);
+        $authRequest->shouldReceive('setUser')->once()->andReturnNull();
+        $authRequest->shouldReceive('setAuthorizationApproved')->once()->with(false);
+
+        $clients = m::mock(ClientRepository::class);
+        $clients->shouldReceive('find')->with(1)->andReturn($client = m::mock(Client::class));
+        $client->shouldReceive('skipsAuthorization')->andReturn(false);
+
+        $tokens = m::mock(TokenRepository::class);
+        $tokens->shouldReceive('findValidToken')
+            ->with($user, $client)
+            ->andReturnNull();
+
+        $controller->authorize(
+            m::mock(ServerRequestInterface::class), $request, $clients, $tokens
+        );
+    }
 }