Skip to content

Commit f5e57f0

Browse files
authored
Change paginage() method return types to \Illuminate\Pagination\LengthAwarePaginator (#54826)
Return types of all the subsequent calls are returning this, which in turn implements `\Illuminate\Contracts\Pagination\LengthAwarePaginator` Related to bmewburn/vscode-intelephense#2912. Which I in turn had issues with locally where calling methods to the returned data from `->paginage()` did not auto complete. Hope this is possible to backport to 11.x too if this is a change that is okay.
1 parent 45f0347 commit f5e57f0

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/Illuminate/Database/Eloquent/Builder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ public function pluck($column, $key = null)
10181018
* @param string $pageName
10191019
* @param int|null $page
10201020
* @param \Closure|int|null $total
1021-
* @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
1021+
* @return \Illuminate\Pagination\LengthAwarePaginator
10221022
*
10231023
* @throws \InvalidArgumentException
10241024
*/

src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ protected function aliasedPivotColumns()
938938
* @param array $columns
939939
* @param string $pageName
940940
* @param int|null $page
941-
* @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
941+
* @return \Illuminate\Pagination\LengthAwarePaginator
942942
*/
943943
public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
944944
{

src/Illuminate/Database/Eloquent/Relations/HasOneOrManyThrough.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ public function get($columns = ['*'])
468468
* @param array $columns
469469
* @param string $pageName
470470
* @param int $page
471-
* @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
471+
* @return \Illuminate\Pagination\LengthAwarePaginator
472472
*/
473473
public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
474474
{

src/Illuminate/Database/Query/Builder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3142,7 +3142,7 @@ protected function withoutGroupLimitKeys($items)
31423142
* @param string $pageName
31433143
* @param int|null $page
31443144
* @param \Closure|int|null $total
3145-
* @return \Illuminate\Contracts\Pagination\LengthAwarePaginator
3145+
* @return \Illuminate\Pagination\LengthAwarePaginator
31463146
*/
31473147
public function paginate($perPage = 15, $columns = ['*'], $pageName = 'page', $page = null, $total = null)
31483148
{

0 commit comments

Comments
 (0)