chore(core): fix some ruff preview rules

cbornet · cbornet · commit 84f7371dc3fb · 2025-12-19T13:17:33.000+01:00
diff --git a/libs/core/langchain_core/example_selectors/length_based.py b/libs/core/langchain_core/example_selectors/length_based.py
@@ -11,7 +11,7 @@
 
 
 def _get_length_based(text: str) -> int:
-    return len(re.split("\n| ", text))
+    return len(re.split(r"\n| ", text))
 
 
 class LengthBasedExampleSelector(BaseExampleSelector, BaseModel):
diff --git a/libs/core/langchain_core/language_models/chat_models.py b/libs/core/langchain_core/language_models/chat_models.py
@@ -547,7 +547,7 @@ def stream(
                         ):
                             if block["type"] != index_type:
                                 index_type = block["type"]
-                                index = index + 1
+                                index += 1
                             if "index" not in block:
                                 block["index"] = index
                     run_manager.on_llm_new_token(
@@ -679,7 +679,7 @@ async def astream(
                     ):
                         if block["type"] != index_type:
                             index_type = block["type"]
-                            index = index + 1
+                            index += 1
                         if "index" not in block:
                             block["index"] = index
                 await run_manager.on_llm_new_token(
@@ -730,7 +730,7 @@ async def astream(
 
     # --- Custom methods ---
 
-    def _combine_llm_outputs(self, llm_outputs: list[dict | None]) -> dict:  # noqa: ARG002
+    def _combine_llm_outputs(self, _llm_outputs: list[dict | None], /) -> dict:
         return {}
 
     def _convert_cached_generations(self, cache_val: list) -> list[ChatGeneration]:
@@ -1187,7 +1187,7 @@ def _generate_with_cache(
                     ):
                         if block["type"] != index_type:
                             index_type = block["type"]
-                            index = index + 1
+                            index += 1
                         if "index" not in block:
                             block["index"] = index
                 if run_manager:
@@ -1305,7 +1305,7 @@ async def _agenerate_with_cache(
                     ):
                         if block["type"] != index_type:
                             index_type = block["type"]
-                            index = index + 1
+                            index += 1
                         if "index" not in block:
                             block["index"] = index
                 if run_manager:
diff --git a/libs/core/langchain_core/messages/ai.py b/libs/core/langchain_core/messages/ai.py
@@ -326,7 +326,7 @@ def _backwards_compat_tool_calls(cls, values: dict) -> Any:
         if tool_calls := values.get("tool_calls"):
             values["tool_calls"] = [
                 create_tool_call(
-                    **{k: v for k, v in tc.items() if k not in ("type", "extras")}
+                    **{k: v for k, v in tc.items() if k not in {"type", "extras"}}
                 )
                 for tc in tool_calls
             ]
@@ -442,7 +442,7 @@ def content_blocks(self) -> list[types.ContentBlock]:
             blocks = [
                 block
                 for block in blocks
-                if block["type"] not in ("tool_call", "invalid_tool_call")
+                if block["type"] not in {"tool_call", "invalid_tool_call"}
             ]
             for tool_call_chunk in self.tool_call_chunks:
                 tc: types.ToolCallChunk = {
@@ -573,7 +573,7 @@ def init_server_tool_calls(self) -> Self:
                 if (
                     isinstance(block, dict)
                     and block.get("type")
-                    in ("server_tool_call", "server_tool_call_chunk")
+                    in {"server_tool_call", "server_tool_call_chunk"}
                     and (args_str := block.get("args"))
                     and isinstance(args_str, str)
                 ):
diff --git a/libs/core/langchain_core/messages/block_translators/anthropic.py b/libs/core/langchain_core/messages/block_translators/anthropic.py
@@ -159,12 +159,12 @@ def _convert_citation_to_v1(citation: dict[str, Any]) -> types.Annotation:
 
         return url_citation
 
-    if citation_type in (
+    if citation_type in {
         "char_location",
         "content_block_location",
         "page_location",
         "search_result_location",
-    ):
+    }:
         document_citation: types.Citation = {
             "type": "citation",
             "cited_text": citation["cited_text"],
@@ -173,8 +173,6 @@ def _convert_citation_to_v1(citation: dict[str, Any]) -> types.Annotation:
             document_citation["title"] = citation["document_title"]
         elif title := citation.get("title"):
             document_citation["title"] = title
-        else:
-            pass
         known_fields = {
             "type",
             "cited_text",
@@ -280,8 +278,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                                     "id": tc.get("id"),
                                 }
                                 break
-                    else:
-                        pass
                     if not tool_call_block:
                         tool_call_block = {
                             "type": "tool_call",
diff --git a/libs/core/langchain_core/messages/block_translators/bedrock_converse.py b/libs/core/langchain_core/messages/block_translators/bedrock_converse.py
@@ -240,8 +240,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                                     "id": tc.get("id"),
                                 }
                                 break
-                    else:
-                        pass
                     if not tool_call_block:
                         tool_call_block = {
                             "type": "tool_call",
diff --git a/libs/core/langchain_core/messages/block_translators/google_genai.py b/libs/core/langchain_core/messages/block_translators/google_genai.py
@@ -411,7 +411,10 @@ def _convert_to_v1_from_genai(message: AIMessage) -> list[types.ContentBlock]:
                         except Exception:
                             # Not valid base64, treat as non-standard
                             converted_blocks.append(
-                                {"type": "non_standard", "value": item}
+                                {
+                                    "type": "non_standard",
+                                    "value": item,
+                                }
                             )
                 else:
                     # This likely won't be reached according to previous implementations
diff --git a/libs/core/langchain_core/messages/block_translators/openai.py b/libs/core/langchain_core/messages/block_translators/openai.py
@@ -248,7 +248,7 @@ def _convert_from_v1_to_chat_completions(message: AIMessage) -> AIMessage:
                 if block_type == "text":
                     # Strip annotations
                     new_content.append({"type": "text", "text": block["text"]})
-                elif block_type in ("reasoning", "tool_call"):
+                elif block_type in {"reasoning", "tool_call"}:
                     pass
                 else:
                     new_content.append(block)
@@ -706,8 +706,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                             if invalid_tool_call.get("id") == call_id:
                                 tool_call_block = invalid_tool_call.copy()
                                 break
-                else:
-                    pass
                 if tool_call_block:
                     if "id" in block:
                         if "extras" not in tool_call_block:
@@ -735,7 +733,7 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                         k: v for k, v in block["action"].items() if k != "sources"
                     }
                 for key in block:
-                    if key not in ("type", "id", "action", "status", "index"):
+                    if key not in {"type", "id", "action", "status", "index"}:
                         web_search_call[key] = block[key]
 
                 yield cast("types.ServerToolCall", web_search_call)
@@ -761,8 +759,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                         web_search_result["status"] = "success"
                     elif status:
                         web_search_result["extras"] = {"status": status}
-                    else:
-                        pass
                     if "index" in block and isinstance(block["index"], int):
                         web_search_result["index"] = f"lc_wsr_{block['index'] + 1}"
                     yield cast("types.ServerToolResult", web_search_result)
@@ -778,14 +774,14 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                     file_search_call["index"] = f"lc_fsc_{block['index']}"
 
                 for key in block:
-                    if key not in (
+                    if key not in {
                         "type",
                         "id",
                         "queries",
                         "results",
                         "status",
                         "index",
-                    ):
+                    }:
                         file_search_call[key] = block[key]
 
                 yield cast("types.ServerToolCall", file_search_call)
@@ -804,8 +800,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                     file_search_result["status"] = "success"
                 elif status:
                     file_search_result["extras"] = {"status": status}
-                else:
-                    pass
                 if "index" in block and isinstance(block["index"], int):
                     file_search_result["index"] = f"lc_fsr_{block['index'] + 1}"
                 yield cast("types.ServerToolResult", file_search_result)
@@ -849,8 +843,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:
                     code_interpreter_result["status"] = "success"
                 elif status:
                     code_interpreter_result["extras"] = {"status": status}
-                else:
-                    pass
                 if "index" in block and isinstance(block["index"], int):
                     code_interpreter_result["index"] = f"lc_cir_{block['index'] + 1}"
 
diff --git a/libs/core/langchain_core/messages/utils.py b/libs/core/langchain_core/messages/utils.py
@@ -1397,7 +1397,7 @@ def convert_to_openai_messages(
                             },
                         }
                     )
-                elif block.get("type") in ["thinking", "reasoning"]:
+                elif block.get("type") in {"thinking", "reasoning"}:
                     content.append(block)
                 else:
                     err = (
diff --git a/libs/core/langchain_core/runnables/graph_png.py b/libs/core/langchain_core/runnables/graph_png.py
@@ -201,7 +201,8 @@ def add_edges(self, viz: Any, graph: Graph) -> None:
                 viz, start, end, str(data) if data is not None else None, cond
             )
 
-    def update_styles(self, viz: Any, graph: Graph) -> None:
+    @staticmethod
+    def update_styles(viz: Any, graph: Graph) -> None:
         """Update the styles of the entrypoint and END nodes.
 
         Args:
diff --git a/libs/core/langchain_core/tools/base.py b/libs/core/langchain_core/tools/base.py
@@ -95,7 +95,7 @@ def _is_annotated_type(typ: type[Any]) -> bool:
     Returns:
         `True` if the type is an Annotated type, `False` otherwise.
     """
-    return get_origin(typ) in (typing.Annotated, typing_extensions.Annotated)
+    return get_origin(typ) in {typing.Annotated, typing_extensions.Annotated}
 
 
 def _get_annotation_description(arg_type: type) -> str | None:
diff --git a/libs/core/langchain_core/tracers/evaluation.py b/libs/core/langchain_core/tracers/evaluation.py
@@ -154,8 +154,8 @@ def _evaluate_in_project(self, run: Run, evaluator: langsmith.RunEvaluator) -> N
                     res
                 )
 
+    @staticmethod
     def _select_eval_results(
-        self,
         results: EvaluationResult | EvaluationResults,
     ) -> list[EvaluationResult]:
         if isinstance(results, EvaluationResult):
diff --git a/libs/core/langchain_core/tracers/langchain.py b/libs/core/langchain_core/tracers/langchain.py
@@ -220,7 +220,8 @@ def _persist_run_single(self, run: Run) -> None:
             log_error_once("post", e)
             raise
 
-    def _update_run_single(self, run: Run) -> None:
+    @staticmethod
+    def _update_run_single(run: Run) -> None:
         """Update a run."""
         if run.extra.get("__disabled"):
             return
diff --git a/libs/core/langchain_core/utils/_merge.py b/libs/core/langchain_core/utils/_merge.py
@@ -58,7 +58,7 @@ def merge_dicts(left: dict[str, Any], *others: dict[str, Any]) -> dict[str, Any]
                 #             "all dicts."
                 #         )
                 if (right_k == "index" and merged[right_k].startswith("lc_")) or (
-                    right_k in ("id", "output_version", "model_provider")
+                    right_k in {"id", "output_version", "model_provider"}
                     and merged[right_k] == right_v
                 ):
                     continue
diff --git a/libs/core/langchain_core/utils/aiter.py b/libs/core/langchain_core/utils/aiter.py
@@ -130,7 +130,7 @@ async def tee_peer(
                     if buffer:
                         continue
                     try:
-                        item = await iterator.__anext__()
+                        item = await anext(iterator)
                     except StopAsyncIteration:
                         break
                     else:
diff --git a/libs/core/langchain_core/utils/function_calling.py b/libs/core/langchain_core/utils/function_calling.py
@@ -247,7 +247,7 @@ def _convert_any_typed_dicts_to_pydantic(
         )
         fields: dict = {}
         for arg, arg_type in annotations_.items():
-            if get_origin(arg_type) in (Annotated, typing_extensions.Annotated):
+            if get_origin(arg_type) in {Annotated, typing_extensions.Annotated}:
                 annotated_args = get_args(arg_type)
                 new_arg_type = _convert_any_typed_dicts_to_pydantic(
                     annotated_args[0], depth=depth + 1, visited=visited
diff --git a/libs/core/langchain_core/utils/mustache.py b/libs/core/langchain_core/utils/mustache.py
@@ -85,7 +85,7 @@ def l_sa_check(
         # If all the characters since the last newline are spaces
         # Then the next tag could be a standalone
         # Otherwise it can't be
-        return padding.isspace() or padding == ""
+        return padding.isspace() or not padding
     return False
 
 
@@ -305,7 +305,7 @@ def tokenize(
 
         # Start yielding
         # Ignore literals that are empty
-        if literal != "":
+        if literal:
             yield ("literal", literal)
 
         # Ignore comments and set delimiters
diff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py
@@ -165,9 +165,9 @@ def eval_response(callback: BaseFakeCallbackHandler, i: int) -> None:
         cb_async = FakeAsyncCallbackHandler()
         llm_astream = llm.astream("Dummy message", config={"callbacks": [cb_async]})
         for _ in range(i):
-            await llm_astream.__anext__()
+            await anext(llm_astream)
         with pytest.raises(FakeListChatModelError):
-            await llm_astream.__anext__()
+            await anext(llm_astream)
         eval_response(cb_async, i)
 
         cb_sync = FakeCallbackHandler()
diff --git a/libs/core/tests/unit_tests/messages/block_translators/test_openai.py b/libs/core/tests/unit_tests/messages/block_translators/test_openai.py
diff --git a/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py b/libs/core/tests/unit_tests/output_parsers/test_pydantic_parser.py
diff --git a/libs/core/tests/unit_tests/runnables/test_runnable.py b/libs/core/tests/unit_tests/runnables/test_runnable.py
diff --git a/libs/core/tests/unit_tests/runnables/test_runnable_events_v1.py b/libs/core/tests/unit_tests/runnables/test_runnable_events_v1.py
diff --git a/libs/core/tests/unit_tests/runnables/test_runnable_events_v2.py b/libs/core/tests/unit_tests/runnables/test_runnable_events_v2.py
diff --git a/libs/core/tests/unit_tests/test_messages.py b/libs/core/tests/unit_tests/test_messages.py
diff --git a/libs/core/tests/unit_tests/tracers/test_langchain.py b/libs/core/tests/unit_tests/tracers/test_langchain.py
diff --git a/libs/core/tests/unit_tests/vectorstores/test_in_memory.py b/libs/core/tests/unit_tests/vectorstores/test_in_memory.py

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,6 @@ def _iter_blocks() -> Iterable[types.ContentBlock]:`
`240`	`240`	`"id": tc.get("id"),`
`241`	`241`	`}`
`242`	`242`	`break`
`243`		`- else:`
`244`		`- pass`
`245`	`243`	`if not tool_call_block:`
`246`	`244`	`tool_call_block = {`
`247`	`245`	`"type": "tool_call",`
Original file line number	Diff line number	Diff line change
`@@ -1397,7 +1397,7 @@ def convert_to_openai_messages(`
`1397`	`1397`	`},`
`1398`	`1398`	`}`
`1399`	`1399`	`)`
`1400`		`- elif block.get("type") in ["thinking", "reasoning"]:`
	`1400`	`+ elif block.get("type") in {"thinking", "reasoning"}:`
`1401`	`1401`	`content.append(block)`
`1402`	`1402`	`else:`
`1403`	`1403`	`err = (`
Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,8 @@ def add_edges(self, viz: Any, graph: Graph) -> None:`
`201`	`201`	`viz, start, end, str(data) if data is not None else None, cond`
`202`	`202`	`)`
`203`	`203`
`204`		`- def update_styles(self, viz: Any, graph: Graph) -> None:`
	`204`	`+ @staticmethod`
	`205`	`+ def update_styles(viz: Any, graph: Graph) -> None:`
`205`	`206`	`"""Update the styles of the entrypoint and END nodes.`
`206`	`207`
`207`	`208`	`Args:`