Skip to content

Commit 6832097

Browse files
authored
Merge pull request containerd#71 from Random-Liu/fix-capabilities
Fix capabilities support.
2 parents 0e003e4 + 4782c59 commit 6832097

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

pkg/server/container_start.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -477,14 +477,15 @@ func setOCICapabilities(g *generate.Generator, capabilities *runtime.Capability,
477477
return nil
478478
}
479479

480+
// Capabilities in CRI doesn't have `CAP_` prefix, so add it.
480481
for _, c := range capabilities.GetAddCapabilities() {
481-
if err := g.AddProcessCapability(c); err != nil {
482+
if err := g.AddProcessCapability("CAP_" + c); err != nil {
482483
return err
483484
}
484485
}
485486

486487
for _, c := range capabilities.GetDropCapabilities() {
487-
if err := g.DropProcessCapability(c); err != nil {
488+
if err := g.DropProcessCapability("CAP_" + c); err != nil {
488489
return err
489490
}
490491
}

pkg/server/container_start_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ func getStartContainerTestData() (*runtime.ContainerConfig, *runtime.PodSandboxC
7777
},
7878
SecurityContext: &runtime.LinuxContainerSecurityContext{
7979
Capabilities: &runtime.Capability{
80-
AddCapabilities: []string{"CAP_SYS_ADMIN"},
81-
DropCapabilities: []string{"CAP_CHOWN"},
80+
AddCapabilities: []string{"SYS_ADMIN"},
81+
DropCapabilities: []string{"CHOWN"},
8282
},
8383
SupplementalGroups: []int64{1111, 2222},
8484
},

0 commit comments

Comments
 (0)