Skip to content

Commit f098592

Browse files
Merge pull request #128584 from thockin/compartmentalize_spew
Compartmentalize spew more Kubernetes-commit: b631dae5696b85411b24d2f2ec94a0cc51ab013c
2 parents 88802cb + 5f2bbac commit f098592

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

cmd/deepcopy-gen/output_tests/output_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import (
2121
"reflect"
2222
"testing"
2323

24-
"github.com/davecgh/go-spew/spew"
25-
"github.com/google/gofuzz"
24+
fuzz "github.com/google/gofuzz"
2625

26+
"k8s.io/apimachinery/pkg/util/dump"
2727
"k8s.io/code-generator/cmd/deepcopy-gen/output_tests/aliases"
2828
"k8s.io/code-generator/cmd/deepcopy-gen/output_tests/builtins"
2929
"k8s.io/code-generator/cmd/deepcopy-gen/output_tests/interfaces"
@@ -60,19 +60,19 @@ func TestWithValueFuzzer(t *testing.T) {
6060
reflectCopy := ReflectDeepCopy(original)
6161

6262
if !reflect.DeepEqual(original, reflectCopy) {
63-
t.Errorf("original and reflectCopy are different:\n\n original = %s\n\n jsonCopy = %s", spew.Sdump(original), spew.Sdump(reflectCopy))
63+
t.Errorf("original and reflectCopy are different:\n\n original = %s\n\n jsonCopy = %s", dump.Pretty(original), dump.Pretty(reflectCopy))
6464
}
6565

6666
deepCopy := reflect.ValueOf(original).MethodByName("DeepCopy").Call(nil)[0].Interface()
6767

6868
if !reflect.DeepEqual(original, deepCopy) {
69-
t.Fatalf("original and deepCopy are different:\n\n original = %s\n\n deepCopy() = %s", spew.Sdump(original), spew.Sdump(deepCopy))
69+
t.Fatalf("original and deepCopy are different:\n\n original = %s\n\n deepCopy() = %s", dump.Pretty(original), dump.Pretty(deepCopy))
7070
}
7171

7272
ValueFuzz(original)
7373

7474
if !reflect.DeepEqual(reflectCopy, deepCopy) {
75-
t.Fatalf("reflectCopy and deepCopy are different:\n\n origin = %s\n\n jsonCopy() = %s", spew.Sdump(original), spew.Sdump(deepCopy))
75+
t.Fatalf("reflectCopy and deepCopy are different:\n\n origin = %s\n\n jsonCopy() = %s", dump.Pretty(original), dump.Pretty(deepCopy))
7676
}
7777
}
7878
})

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,21 @@ go 1.23.0
77
godebug default=go1.23
88

99
require (
10-
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
1110
github.com/gogo/protobuf v1.3.2
1211
github.com/google/gnostic-models v0.6.8
1312
github.com/google/go-cmp v0.6.0
1413
github.com/google/gofuzz v1.2.0
1514
github.com/spf13/pflag v1.0.5
1615
golang.org/x/text v0.19.0
17-
k8s.io/apimachinery v0.0.0-20241105225905-b5e810677b4f
16+
k8s.io/apimachinery v0.0.0-20241106065903-a4471387da34
1817
k8s.io/gengo/v2 v2.0.0-20240911193312-2b36238f13e9
1918
k8s.io/klog/v2 v2.130.1
2019
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f
2120
sigs.k8s.io/yaml v1.4.0
2221
)
2322

2423
require (
24+
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
2525
github.com/emicklei/go-restful/v3 v3.11.0 // indirect
2626
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
2727
github.com/go-logr/logr v1.4.2 // indirect

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ gopkg.in/inf.v0 v0.9.1/go.mod h1:cWUDdTG/fYaXco+Dcufb5Vnc6Gp2YChqWtbxRZE0mXw=
124124
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
125125
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
126126
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
127-
k8s.io/apimachinery v0.0.0-20241105225905-b5e810677b4f h1:MTmedS366tu07Nh6HBoXS90/6DA5gP62gMyYTF+lT+Q=
128-
k8s.io/apimachinery v0.0.0-20241105225905-b5e810677b4f/go.mod h1:HqhdaJUgQqky29T1V0o2yFkt/pZqLFIDyn9Zi/8rxoY=
127+
k8s.io/apimachinery v0.0.0-20241106065903-a4471387da34 h1:o36L3WeM2vPRY0m5SIPqkLfWGE5B+BQTs9+ugxKAaQw=
128+
k8s.io/apimachinery v0.0.0-20241106065903-a4471387da34/go.mod h1:HqhdaJUgQqky29T1V0o2yFkt/pZqLFIDyn9Zi/8rxoY=
129129
k8s.io/gengo/v2 v2.0.0-20240911193312-2b36238f13e9 h1:si3PfKm8dDYxgfbeA6orqrtLkvvIeH8UqffFJDl0bz4=
130130
k8s.io/gengo/v2 v2.0.0-20240911193312-2b36238f13e9/go.mod h1:EJykeLsmFC60UQbYJezXkEsG2FLrt0GPNkU5iK5GWxU=
131131
k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=

0 commit comments

Comments
 (0)