Skip to content

Commit 621e23d

Browse files
authored
Merge pull request #2046 from yaohui-wyh/master
Fix arrayIndexOutOfBounds exception for overloaded addModelMap method
2 parents d03c36a + 482b2b7 commit 621e23d

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

util/src/main/java/io/kubernetes/client/util/ModelMapper.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,11 @@ public class ModelMapper {
8989
@Deprecated
9090
public static void addModelMap(String apiGroupVersion, String kind, Class<?> clazz) {
9191
String[] parts = apiGroupVersion.split("/");
92-
if (parts.length == 1) { // legacy api group
92+
if (parts.length <= 1) { // legacy api group
9393
addModelMap("", apiGroupVersion, kind, clazz);
94+
} else {
95+
addModelMap(parts[0], parts[1], kind, clazz);
9496
}
95-
addModelMap(parts[0], parts[1], kind, clazz);
9697
}
9798

9899
/**

util/src/test/java/io/kubernetes/client/util/ModelMapperTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@ public void testAddingModel() {
5151

5252
assertNull(ModelMapper.getApiTypeClass("example.io/v1", "Tofu"));
5353
assertNull(ModelMapper.getApiTypeClass("example.io", "v1", "Tofu"));
54+
55+
assertNull(ModelMapper.getApiTypeClass("v1", "Togu"));
56+
ModelMapper.addModelMap("v1", "Togu", objClass);
57+
assertEquals(objClass, ModelMapper.getApiTypeClass("", "v1", "Togu"));
58+
assertEquals(objClass, ModelMapper.getApiTypeClass("v1", "Togu"));
5459
}
5560

5661
@Test

0 commit comments

Comments
 (0)