Revert "fix: prevent subnet status update loop in patchSubnetStatus (#7058)" (#7069)

This reverts commit 0221ed9.

Signed-off-by: clyi <clyi@alauda.io>

Author: changluyi

pkg/controller/subnet_status.go

@@ -49,25 +49,22 @@ func (c *Controller) updateNatOutgoingPolicyRulesStatus(subnet *kubeovnv1.Subnet
 func (c *Controller) patchSubnetStatus(subnet *kubeovnv1.Subnet, reason, errStr string) error {
 	if errStr != "" {
 		subnet.Status.SetError(reason, errStr)
-		switch reason {
-		case "ValidateLogicalSwitchFailed":
+		if reason == "ValidateLogicalSwitchFailed" {
 			subnet.Status.NotValidated(reason, errStr)
-		case "ValidateLogicalSwitchSuccess":
+		} else {
 			subnet.Status.Validated(reason, "")
 		}
 		subnet.Status.NotReady(reason, errStr)
 		c.recorder.Eventf(subnet, v1.EventTypeWarning, reason, errStr)
 	} else {
-		switch reason {
-		case "ValidateLogicalSwitchSuccess":
-			subnet.Status.Validated(reason, "")
-		case "SetPrivateLogicalSwitchSuccess",
-			"ResetLogicalSwitchAclSuccess",
-			"ReconcileCentralizedGatewaySuccess",
-			"SetNonOvnSubnetSuccess":
+		subnet.Status.Validated(reason, "")
+		c.recorder.Eventf(subnet, v1.EventTypeNormal, reason, errStr)
+		if reason == "SetPrivateLogicalSwitchSuccess" ||
+			reason == "ResetLogicalSwitchAclSuccess" ||
+			reason == "ReconcileCentralizedGatewaySuccess" ||
+			reason == "SetNonOvnSubnetSuccess" {
 			subnet.Status.Ready(reason, "")
 		}
-		c.recorder.Eventf(subnet, v1.EventTypeNormal, reason, errStr)
 	}
 
 	bytes, err := subnet.Status.Bytes()