Add e2e tests

Signed-off-by: Michal Szadkowski <[email protected]>

Author: mszadkow

test/e2e/mpi_job_test.go

@@ -164,6 +164,30 @@ var _ = ginkgo.Describe("MPIJob", func() {
 				mpiJob := createJobAndWaitForCompletion(mpiJob)
 				expectConditionToBeTrue(mpiJob, kubeflow.JobSucceeded)
 			})
+
+			ginkgo.It("should not complete when managed externaly", func() {
+				mpiJob.Spec.RunPolicy.ManagedBy = ptr.To(kubeflow.MultiKueueController)
+				ctx := context.Background()
+				mpiJob = createJob(ctx, mpiJob)
+
+				err := wait.PollUntilContextTimeout(ctx, waitInterval, foreverTimeout, false, func(ctx context.Context) (bool, error) {
+					updatedJob, err := mpiClient.KubeflowV2beta1().MPIJobs(mpiJob.Namespace).Get(ctx, mpiJob.Name, metav1.GetOptions{})
+					if err != nil {
+						return false, err
+					}
+					mpiJob = updatedJob
+					return mpiJob.Status.CompletionTime != nil, nil
+				})
+				gomega.Expect(err).To(gomega.BeNil())
+
+				// job should be created, but never succeeded
+				condition := getJobCondition(mpiJob, kubeflow.JobCreated)
+				gomega.Expect(condition).ToNot(gomega.BeNil())
+				gomega.Expect(condition.Status).To(gomega.Equal(corev1.ConditionTrue))
+
+				condition = getJobCondition(mpiJob, kubeflow.JobSucceeded)
+				gomega.Expect(condition).To(gomega.BeNil())
+			})
 		})
 
 	})