[Flight] Make PG and FS server-only (facebook#20424)

gaearon · koto · commit a35d1753ef51 · 2021-06-15T13:36:29.000+02:00
* Make react-fs server-only

* Make react-pg server-only
diff --git a/packages/react-fs/index.browser.server.js b/packages/react-fs/index.browser.server.js
diff --git a/packages/react-fs/index.js b/packages/react-fs/index.js
@@ -7,6 +7,7 @@
  * @flow
  */
 
-'use strict';
-
-export * from './index.node';
+throw new Error(
+  'React FS cannot be used outside a react-server environment. ' +
+    'You must configure Node.js using the `--conditions react-server` flag.',
+);
diff --git a/packages/react-fs/index.node.server.js b/packages/react-fs/index.node.server.js
diff --git a/packages/react-fs/npm/index.browser.server.js b/packages/react-fs/npm/index.browser.server.js
@@ -1,7 +1,7 @@
 'use strict';
 
 if (process.env.NODE_ENV === 'production') {
-  module.exports = require('./cjs/react-fs.browser.production.min.js');
+  module.exports = require('./cjs/react-fs.browser.production.min.server.js');
 } else {
-  module.exports = require('./cjs/react-fs.browser.development.js');
+  module.exports = require('./cjs/react-fs.browser.development.server.js');
 }
diff --git a/packages/react-fs/npm/index.js b/packages/react-fs/npm/index.js
@@ -1,3 +1,6 @@
 'use strict';
 
-module.exports = require('./index.node');
+throw new Error(
+  'React FS cannot be used outside a react-server environment. ' +
+    'You must configure Node.js using the `--conditions react-server` flag.'
+);
diff --git a/packages/react-fs/npm/index.node.js b/packages/react-fs/npm/index.node.js
diff --git a/packages/react-fs/npm/index.node.server.js b/packages/react-fs/npm/index.node.server.js
@@ -0,0 +1,7 @@
+'use strict';
+
+if (process.env.NODE_ENV === 'production') {
+  module.exports = require('./cjs/react-fs.node.production.min.server.js');
+} else {
+  module.exports = require('./cjs/react-fs.node.development.server.js');
+}
diff --git a/packages/react-fs/package.json b/packages/react-fs/package.json
@@ -13,14 +13,23 @@
     "README.md",
     "build-info.json",
     "index.js",
-    "index.node.js",
-    "index.browser.js",
+    "index.node.server.js",
+    "index.browser.server.js",
     "cjs/"
   ],
+  "exports": {
+    ".": {
+      "react-server": {
+        "node": "./index.node.server.js",
+        "browser": "./index.browser.server.js"
+      },
+      "default": "./index.js"
+    },
+    "./index.node.server": "./index.node.server.js",
+    "./index.browser.server": "./index.browser.server.js",
+    "./package.json": "./package.json"
+  },
   "peerDependencies": {
     "react": "^17.0.0"
-  },
-  "browser": {
-    "./index.js": "./index.browser.js"
   }
 }
diff --git a/packages/react-pg/index.browser.server.js b/packages/react-pg/index.browser.server.js
diff --git a/packages/react-pg/index.js b/packages/react-pg/index.js
@@ -7,6 +7,7 @@
  * @flow
  */
 
-'use strict';
-
-export * from './index.node';
+throw new Error(
+  'React PG cannot be used outside a react-server environment. ' +
+    'You must configure Node.js using the `--conditions react-server` flag.',
+);
diff --git a/packages/react-pg/index.node.server.js b/packages/react-pg/index.node.server.js
diff --git a/packages/react-pg/npm/index.browser.server.js b/packages/react-pg/npm/index.browser.server.js
@@ -1,7 +1,7 @@
 'use strict';
 
 if (process.env.NODE_ENV === 'production') {
-  module.exports = require('./cjs/react-pg.browser.production.min.js');
+  module.exports = require('./cjs/react-pg.browser.production.min.server.js');
 } else {
-  module.exports = require('./cjs/react-pg.browser.development.js');
+  module.exports = require('./cjs/react-pg.browser.development.server.js');
 }
diff --git a/packages/react-pg/npm/index.js b/packages/react-pg/npm/index.js
@@ -1,3 +1,6 @@
 'use strict';
 
-module.exports = require('./index.node');
+throw new Error(
+  'React PG cannot be used outside a react-server environment. ' +
+    'You must configure Node.js using the `--conditions react-server` flag.'
+);
diff --git a/packages/react-pg/npm/index.node.js b/packages/react-pg/npm/index.node.js
diff --git a/packages/react-pg/npm/index.node.server.js b/packages/react-pg/npm/index.node.server.js
@@ -0,0 +1,7 @@
+'use strict';
+
+if (process.env.NODE_ENV === 'production') {
+  module.exports = require('./cjs/react-pg.node.production.min.server.js');
+} else {
+  module.exports = require('./cjs/react-pg.node.development.server.js');
+}
diff --git a/packages/react-pg/package.json b/packages/react-pg/package.json
@@ -13,15 +13,24 @@
     "README.md",
     "build-info.json",
     "index.js",
-    "index.node.js",
-    "index.browser.js",
+    "index.node.server.js",
+    "index.browser.server.js",
     "cjs/"
   ],
+  "exports": {
+    ".": {
+      "react-server": {
+        "node": "./index.node.server.js",
+        "browser": "./index.browser.server.js"
+      },
+      "default": "./index.js"
+    },
+    "./index.node.server": "./index.node.server.js",
+    "./index.browser.server": "./index.browser.server.js",
+    "./package.json": "./package.json"
+  },
   "peerDependencies": {
     "react": "^17.0.0",
     "pg": "*"
-  },
-  "browser": {
-    "./index.js": "./index.browser.js"
   }
 }
diff --git a/packages/react-server-dom-webpack/package.json b/packages/react-server-dom-webpack/package.json
@@ -38,9 +38,6 @@
     "./node-register": "./node-register.js",
     "./package.json": "./package.json"
   },
-  "browser": {
-    "./writer.js": "./writer.browser.server.js"
-  },
   "main": "index.js",
   "repository": {
     "type" : "git",
diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js
@@ -157,7 +157,7 @@ const bundles = [
   {
     bundleTypes: [NODE_DEV, NODE_PROD],
     moduleType: ISOMORPHIC,
-    entry: 'react-fs/index.browser',
+    entry: 'react-fs/index.browser.server',
     global: 'ReactFilesystem',
     externals: [],
   },
@@ -166,7 +166,7 @@ const bundles = [
   {
     bundleTypes: [NODE_DEV, NODE_PROD],
     moduleType: ISOMORPHIC,
-    entry: 'react-fs/index.node',
+    entry: 'react-fs/index.node.server',
     global: 'ReactFilesystem',
     externals: ['react', 'fs/promises', 'path'],
   },
@@ -175,7 +175,7 @@ const bundles = [
   {
     bundleTypes: [NODE_DEV, NODE_PROD],
     moduleType: ISOMORPHIC,
-    entry: 'react-pg/index.browser',
+    entry: 'react-pg/index.browser.server',
     global: 'ReactPostgres',
     externals: [],
   },
@@ -184,7 +184,7 @@ const bundles = [
   {
     bundleTypes: [NODE_DEV, NODE_PROD],
     moduleType: ISOMORPHIC,
-    entry: 'react-pg/index.node',
+    entry: 'react-pg/index.node.server',
     global: 'ReactPostgres',
     externals: ['react', 'pg'],
   },

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`'use strict';`
`2`	`2`
`3`	`3`	`if (process.env.NODE_ENV === 'production') {`
`4`		`- module.exports = require('./cjs/react-fs.browser.production.min.js');`
	`4`	`+ module.exports = require('./cjs/react-fs.browser.production.min.server.js');`
`5`	`5`	`} else {`
`6`		`- module.exports = require('./cjs/react-fs.browser.development.js');`
	`6`	`+ module.exports = require('./cjs/react-fs.browser.development.server.js');`
`7`	`7`	`}`