Skip to content

Added shouldBeZero and shouldNotBeZero matcher for number types (#819)#848

Merged
sksamuel merged 6 commits into
kotest:masterfrom
faogustavo:feature/number-should-be-zero
Jun 23, 2019
Merged

Added shouldBeZero and shouldNotBeZero matcher for number types (#819)#848
sksamuel merged 6 commits into
kotest:masterfrom
faogustavo:feature/number-should-be-zero

Conversation

@faogustavo

@faogustavo faogustavo commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

Closes #819

I've also added the same matcher for floats (idn if it was necessary, because if it was not described on the task).
Also, there was a matcher file with just a couple of rules on the numerics package, so I joined with the existing one with more rules. Did the same with floats with to keep the same pattern from other numerics.

@hjJunior hjJunior left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, just give another look about new line at end of file

Comment thread kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/FloatMatchers.kt Outdated
Comment thread kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/IntMatchers.kt Outdated
@sksamuel sksamuel self-requested a review June 21, 2019 13:57

@sksamuel sksamuel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zero stuff is awesome and can be merged.
The float stuff needs change as per request.
Thanks!

Comment thread kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/FloatMatchers.kt Outdated
@sksamuel

sksamuel commented Jun 21, 2019 via email

Copy link
Copy Markdown
Member

@faogustavo

Copy link
Copy Markdown
Contributor Author

@sksamuel can you see if it's ok now?

@sksamuel sksamuel merged commit 916205d into kotest:master Jun 23, 2019
@sksamuel

Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ShouldBeZero matcher

3 participants