Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Commit c70356c

Browse files
authored
Merge pull request #634 from roiLeo/fix/securiry/_blank
fix(security): rel on target _blank link
2 parents 79f6c00 + 79f8dea commit c70356c

File tree

13 files changed

+25
-16
lines changed

13 files changed

+25
-16
lines changed

src/components/landing/Tutorials.vue

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<!-- <router-link :to="{name: 'createAccount'}"> -->
1818
<a
1919
target="_blank"
20+
rel="noopener noreferrer"
2021
href="https://www.youtube.com/watch?v=iG8iQrONnYo"
2122
>
2223
<b-button type="is-primary" class="mb-6">
@@ -27,6 +28,7 @@
2728
<!-- <router-link :to="{name: 'createAccount'}"> -->
2829
<a
2930
target="_blank"
31+
rel="noopener noreferrer"
3032
href="https://www.youtube.com/watch?v=cYaZWDzU1Yc"
3133
>
3234
<b-button type="is-primary" class="mb-6">
@@ -37,6 +39,7 @@
3739
<!-- <router-link :to="{name: 'createAccount'}"> -->
3840
<a
3941
target="_blank"
42+
rel="noopener noreferrer"
4043
href="https://www.youtube.com/watch?v=pPsbQyJRGVQ"
4144
>
4245
<b-button type="is-primary" class="mb-6">

src/components/rmrk/Credit/Credit.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
+ `&hostLogoUrl=https://nft.kodadot.xyz/kodadot_logo_v1_transparent_400px.png`
1919
+ `&finalUrl=https://nft.kodadot.xyz`
2020
+ `hostApiKey=a99bfvomhhbvzy6thaycxbawz7d3pssuz2a8hsrc`"
21-
target="_blank" >
21+
target="_blank"
22+
rel="noopener noreferrer"
23+
>
2224
Buy Kusama
2325
</b-button><br>
2426
</div>

src/components/rmrk/Gallery/Item/Facts.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<ol>
4141
<li v-for="gw in gwList"
4242
:key="gw">
43-
<a :href="gw+imageId" target="_blank">Gateway</a>
43+
<a :href="gw+imageId" target="_blank" rel="noopener noreferrer">Gateway</a>
4444
</li>
4545
</ol>
4646
</p>

src/components/rmrk/Media/Unknown.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<template>
22
<div>
3-
<a :href="src" target="_blank">Unknown animated media, click to download</a>
3+
<a :href="src" target="_blank" rel="noopener noreferrer">Unknown animated media, click to download</a>
44
</div>
55
</template>
66

src/components/rmrk/Profile/NavbarProfileDropdown.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@
3232
</b-dropdown-item>
3333
<hr class="dropdown-divider" aria-role="menuitem" />
3434
<b-dropdown-item has-link aria-role="menuitem">
35-
<a href="https://twitter.com/kodadot" target="_blank" class="is-flex is-align-items-center pl-3">
35+
<a href="https://twitter.com/kodadot" target="_blank" rel="noopener noreferrer" class="is-flex is-align-items-center pl-3">
3636
<b-icon pack="fab" icon="twitter" class="mr-1"> </b-icon>
3737
<strong>KodaDot</strong>
3838
</a>
3939
</b-dropdown-item>
4040
<b-dropdown-item has-link aria-role="menuitem">
41-
<a href="https://discord.gg/u6ymnbz4PR" target="_blank" class="is-flex is-align-items-center pl-3">
41+
<a href="https://discord.gg/u6ymnbz4PR" target="_blank" rel="noopener noreferrer" class="is-flex is-align-items-center pl-3">
4242
<b-icon pack="fab" icon="discord" class="mr-1"> </b-icon>
4343
<strong>Discord</strong>
4444
</a>

src/components/rmrk/Profile/ProfileLink.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<LinkResolver class="profile-link__wrapper" route="profile" :param="address" link="u">
44
<Identity :address="address" :inline="true" :verticalAlign="true" />
55
<template v-slot:extra>
6-
<a :href="`https://kusama.subscan.io/account/${address}`" target="_blank">
6+
<a :href="`https://kusama.subscan.io/account/${address}`" target="_blank" rel="noopener noreferrer">
77
<figure class="image is-24x24 subscan__less-margin">
88
<img alt="subscan" :src="require('@/assets/subscan.svg')" />
99
</figure>

src/components/shared/Card.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
role="button"
1010
aria-controls="contentIdForA11y3">
1111
<p class="card-header-title">
12-
<a :href="getExplorerUrl(nature)" target="_blank">
12+
<a :href="getExplorerUrl(nature)" target="_blank" rel="noopener noreferrer">
1313
🧊 {{nature}}</a>
1414
</p>
1515
<a class="card-header-icon">
@@ -20,7 +20,7 @@
2020
</div>
2121
<div class="card-content">
2222
<div class="content truncate">
23-
<a :href="getExplorerUrl(natureDesc)" target="_blank">
23+
<a :href="getExplorerUrl(natureDesc)" target="_blank" rel="noopener noreferrer">
2424
{{natureDesc}}</a>
2525
</div>
2626
</div>

src/components/shared/LinkResolver.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<slot name="extra" />
88
</template>
99
<template v-else>
10-
<a :href="hrefLink" target="_blank" rel="noopener">
10+
<a :href="hrefLink" target="_blank" rel="noopener noreferrer">
1111
<slot />
1212
</a>
1313
</template>

src/components/shared/accounts/Keypair.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<router-link :to="{name:'transferFrom', params:{ from: address}}">
7474
<b-button type="is-dark" icon-left="paper-plane" outlined>Send</b-button>
7575
</router-link>
76-
<a :href="getExplorerUrl(address)" target="_blank">
76+
<a :href="getExplorerUrl(address)" target="_blank" rel="noopener noreferrer">
7777
<b-button type="is-dark" icon-left="external-link-alt" outlined>View</b-button>
7878
</a>
7979
</b-field>
@@ -86,7 +86,7 @@
8686
<router-link :to="{name:'transferTo', params:{ to: address}}">
8787
<b-button type="is-dark" icon-left="paper-plane" outlined>Deposit</b-button>
8888
</router-link>
89-
<a :href="getExplorerUrl(address)" target="_blank">
89+
<a :href="getExplorerUrl(address)" target="_blank" rel="noopener noreferrer">
9090
<b-button type="is-dark" icon-left="external-link-alt" outlined>View</b-button>
9191
</a>
9292
</b-field>

src/components/shared/format/ExternalLink.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<a :href="id ? url+id : url" target="_blank">
2+
<a :href="id ? url+id : url" target="_blank" rel="noopener noreferrer">
33
<slot></slot>
44
</a>
55
</template>

0 commit comments

Comments
 (0)