Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Commit 31632ac

Browse files
authored
Merge pull request #1597 from kkukelka/fix/twitter-hashtag
1462 fix hastags in twitter and facebook sharing
2 parents 6d96093 + a9578f5 commit 31632ac

File tree

7 files changed

+16
-6
lines changed

7 files changed

+16
-6
lines changed

components/rmrk/Gallery/Item/Sharing.vue

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
tag="button"
3030
class="button share__button is-medium"
3131
network="twitter"
32+
:hashtags="hashtags"
3233
:url="realworldFullPath"
3334
:title="label"
3435
twitter-user="KodaDot"
@@ -48,6 +49,7 @@
4849
tag="button"
4950
class="button share__button is-medium"
5051
network="facebook"
52+
:hashtags="hashtags"
5153
:url="realworldFullPath"
5254
:title="label"
5355
>
@@ -118,12 +120,14 @@ const components = {
118120
components,
119121
})
120122
export default class Sharing extends Vue {
121-
@Prop({ default: 'Check this cool NFT on #KusamaNetwork #KodaDot' }) label!: string
123+
@Prop({ default: 'Check out this cool NFT on KodaDot' }) label!: string
122124
@Prop({ default: () => emptyIframe }) iframe!: IFrame
123125
@Prop(Boolean) onlyCopyLink!: boolean
124126
125127
private active = false
126128
129+
private hashtags = ['KusamaNetwork', 'KodaDot']
130+
127131
get helloText(): string {
128132
return this.label
129133
}

components/rmrk/Pack/PackItem.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</p>
1616
<Sharing
1717
v-if="sharingVisible"
18-
label="Check this awesome Pack on %23KusamaNetwork %23KodaDot"
18+
:label="$t('sharing.pack')"
1919
:iframe="iframeSettings"
2020
/>
2121
</div>

components/unique/Collection/Item/CollectionItem.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
</div>
3737
<div class="column is-2">
3838
<Sharing v-if="sharingVisible"
39-
label="Check this awesome Collection on %23KusamaNetwork %23KodaDot"
39+
:label="$t('sharing.collection')"
4040
:iframe="iframeSettings" >
4141
<TransferCollection v-if="accountIsCurrentOwner" :collectionId="id" :currentOwnerId="currentOwner" :accountId="accountId" />
4242
</Sharing>

langDir/en.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,5 +549,11 @@
549549
"hide": "Hide on-chain attributes"
550550
}
551551
}
552+
},
553+
"sharing": {
554+
"collection": "Check out this awesome Collection on KodaDot",
555+
"nft": "Check out this awesome NFT on KodaDot",
556+
"pack": "Check out this awesome Pack on KodaDot",
557+
"profile": "Check out this awesome Profile on KodaDot"
552558
}
553559
}

pages/rmrk/u/_id.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<Sharing
3737
class="mb-2"
3838
v-if="!sharingVisible"
39-
label="Check this awesome Profile on %23KusamaNetwork %23KodaDot"
39+
:label="$t('sharing.profile')"
4040
:iframe="iframeSettings"
4141
>
4242
<DonationButton :address="id" />

pages/statemine/u/_id.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<Sharing
3838
class="mb-2"
3939
v-if="!sharingVisible"
40-
label="Check this awesome Profile on %23KusamaNetwork %23KodaDot"
40+
:label="$t('sharing.profile')"
4141
:iframe="iframeSettings"
4242
>
4343
<DonationButton :address="id" />

pages/westmint/u/_id.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<Sharing
3838
class="mb-2"
3939
v-if="!sharingVisible"
40-
label="Check this awesome Profile on %23KusamaNetwork %23KodaDot"
40+
:label="$t('sharing.profile')"
4141
:iframe="iframeSettings"
4242
>
4343
<DonationButton :address="id" />

0 commit comments

Comments
 (0)