Remove FrameDamage::ignore_damage_

Author: knopp

flow/compositor_context.h

@@ -91,20 +91,17 @@ class FrameDamage {
 
   // See Damage::buffer_damage.
   std::optional<SkIRect> GetBufferDamage() {
-    return (damage_ && !ignore_damage_)
-               ? std::make_optional(damage_->buffer_damage)
-               : std::nullopt;
+    return damage_ ? std::make_optional(damage_->buffer_damage) : std::nullopt;
   }
 
-  void Reset() { ignore_damage_ = true; }
+  void Reset() { damage_ = std::nullopt; }
 
  private:
   SkIRect additional_damage_ = SkIRect::MakeEmpty();
   std::optional<Damage> damage_;
   const LayerTree* prev_layer_tree_ = nullptr;
   int vertical_clip_alignment_ = 1;
   int horizontal_clip_alignment_ = 1;
-  bool ignore_damage_ = false;
 };
 
 class CompositorContext {

shell/gpu/gpu_surface_metal_impeller.mm

@@ -77,6 +77,7 @@
       fml::MakeCopyable([this,                           //
                          renderer = impeller_renderer_,  //
                          aiks_context = aiks_context_,   //
+                         frame_info = frame_info,        //
                          metal_drawable                  //
   ](SurfaceFrame& surface_frame, DlCanvas* canvas) mutable -> bool {
         if (!aiks_context) {
@@ -97,6 +98,9 @@
               // Accumulate damage for other framebuffers
               if (surface_frame.submit_info().frame_damage) {
                 entry.second.join(*surface_frame.submit_info().frame_damage);
+              } else {
+                // Not getting frame damage assume whole frame is repainted.
+                entry.second.join(SkIRect::MakeSize(frame_info));
               }
             }
           }