-
Notifications
You must be signed in to change notification settings - Fork 34
Fix probing when KIngress has multiple visibilities (External/ClusterLocal) #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix probing when KIngress has multiple visibilities (External/ClusterLocal) #693
Conversation
…e flips while reconciling
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @izabelacg |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
===========================================
+ Coverage 66.97% 78.05% +11.08%
===========================================
Files 15 16 +1
Lines 863 1103 +240
===========================================
+ Hits 578 861 +283
+ Misses 254 203 -51
- Partials 31 39 +8 ☔ View full report in Codecov by Sentry. |
/lgtm |
Serving uses multiple visibilities in it's KIngress which triggered a problem in the three phase probing.
This issue fixes that problem and adds the serving specific test cases
Fixes: #18
Unblocks - knative/serving#15136