Skip to content

Fix probing when KIngress has multiple visibilities (External/ClusterLocal) #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Apr 19, 2024

Serving uses multiple visibilities in it's KIngress which triggered a problem in the three phase probing.

This issue fixes that problem and adds the serving specific test cases

Fixes: #18

Unblocks - knative/serving#15136

@knative-prow knative-prow bot requested review from ReToCode and skonto April 19, 2024 12:17
Copy link

knative-prow bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 19, 2024
@dprotaso
Copy link
Contributor Author

/assign @izabelacg

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.05%. Comparing base (cd525ad) to head (b134949).
Report is 24 commits behind head on main.

Files Patch % Lines
pkg/reconciler/ingress/reconcile_resources.go 80.76% 5 Missing ⚠️
pkg/reconciler/ingress/ingress.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #693       +/-   ##
===========================================
+ Coverage   66.97%   78.05%   +11.08%     
===========================================
  Files          15       16        +1     
  Lines         863     1103      +240     
===========================================
+ Hits          578      861      +283     
+ Misses        254      203       -51     
- Partials       31       39        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso dprotaso changed the title Fix hash mutation Fix probing when KIngress has multiple visibilities (External/ClusterLocal) Apr 19, 2024
@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@knative-prow knative-prow bot merged commit b97c6b6 into knative-extensions:main Apr 19, 2024
@dprotaso dprotaso deleted the fix-hash-mutation branch April 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a plan of the KIngress prober for HTTPRoute
2 participants