Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Commit 5c2de91

Browse files
invidianiaguis
andauthored
Apply suggestions from code review
Co-authored-by: Iago López Galeiras <iago@kinvolk.io>
1 parent 56bf0c7 commit 5c2de91

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/platform/aks/aks.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ func (c *config) PostApplyHook(kubeconfig []byte) error {
331331
return waitForDefaultStorageClass(client.StorageV1().StorageClasses())
332332
}
333333

334-
// waitForDefaultStorageClass wait until default storage class appears on a given cluster.
335-
// If it doesn't within defined time range, error is returned.
334+
// waitForDefaultStorageClass waits until the default storage class appears on a given cluster.
335+
// If it doesn't appear within a defined time range, an error is returned.
336336
func waitForDefaultStorageClass(sci v1.StorageClassInterface) error {
337337
// AKS still uses annotation with .beta.
338338
defaultStorageClassAnnotation := "storageclass.beta.kubernetes.io/is-default-class"

pkg/platform/platform.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ type Platform interface {
7474
Meta() Meta
7575
}
7676

77-
// PostApplyHook is an interface, which platforms may optionally implement. If they do so,
78-
// after Terraform finishes applying, kubeconfig content will be passed to this function and
79-
// executed. This allows running sanity checks on the newly created cluster.
77+
// PostApplyHook runs code after Terraform finishes applying. This allows
78+
// running sanity checks on the newly created cluster. Implementing this
79+
// interface is optional for platforms.
8080
type PostApplyHook interface {
8181
PostApplyHook(kubeconfig []byte) error
8282
}

0 commit comments

Comments
 (0)