Skip to content

Commit 3470da3

Browse files
adam900710kdave
authored andcommitted
btrfs: subpage: introduce helpers for writeback status
Introduces the following functions to handle subpage writeback status: - btrfs_subpage_set_writeback() - btrfs_subpage_clear_writeback() - btrfs_subpage_test_writeback() These helpers can only be called when the range is ensured to be inside the page. - btrfs_page_set_writeback() - btrfs_page_clear_writeback() - btrfs_page_test_writeback() These helpers can handle both regular sector size and subpage without problem. Signed-off-by: Qu Wenruo <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent d8a5713 commit 3470da3

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

fs/btrfs/subpage.c

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,33 @@ void btrfs_subpage_clear_dirty(const struct btrfs_fs_info *fs_info,
269269
clear_page_dirty_for_io(page);
270270
}
271271

272+
void btrfs_subpage_set_writeback(const struct btrfs_fs_info *fs_info,
273+
struct page *page, u64 start, u32 len)
274+
{
275+
struct btrfs_subpage *subpage = (struct btrfs_subpage *)page->private;
276+
u16 tmp = btrfs_subpage_calc_bitmap(fs_info, page, start, len);
277+
unsigned long flags;
278+
279+
spin_lock_irqsave(&subpage->lock, flags);
280+
subpage->writeback_bitmap |= tmp;
281+
set_page_writeback(page);
282+
spin_unlock_irqrestore(&subpage->lock, flags);
283+
}
284+
285+
void btrfs_subpage_clear_writeback(const struct btrfs_fs_info *fs_info,
286+
struct page *page, u64 start, u32 len)
287+
{
288+
struct btrfs_subpage *subpage = (struct btrfs_subpage *)page->private;
289+
u16 tmp = btrfs_subpage_calc_bitmap(fs_info, page, start, len);
290+
unsigned long flags;
291+
292+
spin_lock_irqsave(&subpage->lock, flags);
293+
subpage->writeback_bitmap &= ~tmp;
294+
if (subpage->writeback_bitmap == 0)
295+
end_page_writeback(page);
296+
spin_unlock_irqrestore(&subpage->lock, flags);
297+
}
298+
272299
/*
273300
* Unlike set/clear which is dependent on each page status, for test all bits
274301
* are tested in the same way.
@@ -290,6 +317,7 @@ bool btrfs_subpage_test_##name(const struct btrfs_fs_info *fs_info, \
290317
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(uptodate);
291318
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(error);
292319
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(dirty);
320+
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(writeback);
293321

294322
/*
295323
* Note that, in selftests (extent-io-tests), we can have empty fs_info passed
@@ -328,3 +356,5 @@ IMPLEMENT_BTRFS_PAGE_OPS(uptodate, SetPageUptodate, ClearPageUptodate,
328356
IMPLEMENT_BTRFS_PAGE_OPS(error, SetPageError, ClearPageError, PageError);
329357
IMPLEMENT_BTRFS_PAGE_OPS(dirty, set_page_dirty, clear_page_dirty_for_io,
330358
PageDirty);
359+
IMPLEMENT_BTRFS_PAGE_OPS(writeback, set_page_writeback, end_page_writeback,
360+
PageWriteback);

fs/btrfs/subpage.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ struct btrfs_subpage {
2121
u16 uptodate_bitmap;
2222
u16 error_bitmap;
2323
u16 dirty_bitmap;
24+
u16 writeback_bitmap;
2425
union {
2526
/*
2627
* Structures only used by metadata
@@ -89,6 +90,7 @@ bool btrfs_page_test_##name(const struct btrfs_fs_info *fs_info, \
8990
DECLARE_BTRFS_SUBPAGE_OPS(uptodate);
9091
DECLARE_BTRFS_SUBPAGE_OPS(error);
9192
DECLARE_BTRFS_SUBPAGE_OPS(dirty);
93+
DECLARE_BTRFS_SUBPAGE_OPS(writeback);
9294

9395
bool btrfs_subpage_clear_and_test_dirty(const struct btrfs_fs_info *fs_info,
9496
struct page *page, u64 start, u32 len);

0 commit comments

Comments
 (0)