ci: enforce golangci-lint in Makefile and CI workflows

Signed-off-by: Todd Ekenstam <[email protected]>

Author: tekenstam

.github/workflows/push.yml

@@ -16,6 +16,21 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v4
 
+    - name: Set up Go 1.x
+      uses: actions/setup-go@v5
+      with:
+        go-version: 1.24
+
+    - name: Run golangci-lint
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.55.2
+        args: --timeout=3m
+
+    - name: Test
+      run: |
+        make test
+
     - name: Set up Docker Buildx
       id: buildx
       uses: docker/setup-buildx-action@v3
@@ -59,4 +74,3 @@ jobs:
         platforms: linux/amd64,linux/arm/v7,linux/arm64
         push: true
         tags: ${{ steps.docker_meta.outputs.tags }}
-

.github/workflows/unit-test.yml

@@ -24,7 +24,6 @@ jobs:
       uses: golangci/golangci-lint-action@v3
       with:
         version: v1.55.2
-        only-new-issues: true
         args: --timeout=3m
 
     - name: Initialize CodeQL

Makefile

@@ -30,11 +30,11 @@ IMG ?= instance-manager:latest
 INSTANCEMGR_TAG ?= latest
 
 .PHONY: all
-all: check-go test clean manager
+all: check-go lint test clean manager
 
 # Run tests
 .PHONY: test
-test: generate fmt vet manifests
+test: generate fmt vet manifests lint
 	go test ./controllers/... ./api/... -coverprofile coverage.txt
 
 .PHONY: bdd
@@ -126,7 +126,7 @@ endif
 .PHONY: lint
 lint: check-go
 	@echo "Running golangci-lint"
-	golangci-lint run ./... || echo "Linting errors found - these will be enforced in the future"
+	golangci-lint run ./...
 
 .PHONY: clean
 clean: