fix: LaunchTemplates to set InstanceMetadataTags as "disabled" (#503)

kevdowney · web-flow · commit 446043e82564 · 2025-07-15T09:51:08.000-07:00
* chore: ignore local files

Signed-off-by: Kevin Downey &lt;kevdowney@gmail.com&gt;

* fix: set InstanceMetadataTags "disabled"

Signed-off-by: Kevin Downey &lt;kevdowney@gmail.com&gt;

* chore: add tests for InstanceMetadataTags disabled

Signed-off-by: Kevin Downey &lt;kevdowney@gmail.com&gt;

* chore: run make manifests

Signed-off-by: Kevin Downey &lt;kevdowney@gmail.com&gt;

---------

Signed-off-by: Kevin Downey &lt;kevdowney@gmail.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -9,3 +9,4 @@ vendor/*
 *.idea
 .windsurfrules
 .qodo
+.tool-versions
diff --git a/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml b/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml
@@ -78,8 +78,6 @@ spec:
                 properties:
                   configuration:
                     properties:
-                      nodeConfig:
-                        type: string
                       bootstrapArguments:
                         type: string
                       bootstrapOptions:
diff --git a/controllers/provisioners/eks/scaling/launchtemplate.go b/controllers/provisioners/eks/scaling/launchtemplate.go
@@ -364,6 +364,7 @@ func (lt *LaunchTemplate) metadataOptions(input *v1alpha1.MetadataOptions) *ec2.
 		HttpEndpoint:            aws.String(input.HttpEndpoint),
 		HttpPutResponseHopLimit: aws.Int64(input.HttpPutHopLimit),
 		HttpTokens:              aws.String(input.HttpTokens),
+		InstanceMetadataTags:    aws.String("disabled"), // set disabled by default
 	}
 }
 
@@ -375,6 +376,7 @@ func (lt *LaunchTemplate) metadataOptionsRequest(input *v1alpha1.MetadataOptions
 		HttpEndpoint:            aws.String(input.HttpEndpoint),
 		HttpPutResponseHopLimit: aws.Int64(input.HttpPutHopLimit),
 		HttpTokens:              aws.String(input.HttpTokens),
+		InstanceMetadataTags:    aws.String("disabled"), // set disabled by default
 	}
 }
 
diff --git a/controllers/provisioners/eks/scaling/launchtemplate_test.go b/controllers/provisioners/eks/scaling/launchtemplate_test.go

Original file line number	Diff line number	Diff line change
`@@ -364,6 +364,7 @@ func (lt LaunchTemplate) metadataOptions(input v1alpha1.MetadataOptions) *ec2.`
`364`	`364`	`HttpEndpoint: aws.String(input.HttpEndpoint),`
`365`	`365`	`HttpPutResponseHopLimit: aws.Int64(input.HttpPutHopLimit),`
`366`	`366`	`HttpTokens: aws.String(input.HttpTokens),`
	`367`	`+ InstanceMetadataTags: aws.String("disabled"), // set disabled by default`
`367`	`368`	`}`
`368`	`369`	`}`
`369`	`370`
`@@ -375,6 +376,7 @@ func (lt LaunchTemplate) metadataOptionsRequest(input v1alpha1.MetadataOptions`
`375`	`376`	`HttpEndpoint: aws.String(input.HttpEndpoint),`
`376`	`377`	`HttpPutResponseHopLimit: aws.Int64(input.HttpPutHopLimit),`
`377`	`378`	`HttpTokens: aws.String(input.HttpTokens),`
	`379`	`+ InstanceMetadataTags: aws.String("disabled"), // set disabled by default`
`378`	`380`	`}`
`379`	`381`	`}`
`380`	`382`