interceptor: make request logging optional

Signed-off-by: Jan Wozniak <[email protected]>

Author: wozniakjan

CHANGELOG.md

@@ -31,7 +31,7 @@ This changelog keeps track of work items that have been completed and are ready
 
 ### Improvements
 
-- **General**: TODO ([#TODO](https://github.com/kedacore/http-add-on/issues/TODO))
+- **General**: Make interceptor request logging optional ([#1375](https://github.com/kedacore/http-add-on/pull/1375))
 
 ### Fixes
 

docs/operate.md

@@ -70,4 +70,8 @@ Optional variables
 `OTEL_EXPORTER_OTLP_TRACES_INSECURE` - To send traces to the tracing via HTTP rather than HTTPS (`false` by default)
 `OTEL_EXPORTER_OTLP_TRACES_TIMEOUT` - The batcher timeout in seconds to send batch of data points (`5` by default)
 
+### Configuring interceptor proxy request logging
+
+The interceptor proxy can log incoming requests for debugging and monitoring purposes. Request logging can be enabled by setting the `KEDA_HTTP_LOG_REQUESTS` environment variable to `true` on the interceptor deployment (`false` by default).
+
 ### Configuring Service Failover

interceptor/config/serving.go

@@ -51,6 +51,8 @@ type Serving struct {
 	ProfilingAddr string `envconfig:"PROFILING_BIND_ADDRESS" default:""`
 	// EnableColdStartHeader enables/disables the X-KEDA-HTTP-Cold-Start response header
 	EnableColdStartHeader bool `envconfig:"KEDA_HTTP_ENABLE_COLD_START_HEADER" default:"true"`
+	// LogRequests enables/disables logging of incoming requests
+	LogRequests bool `envconfig:"KEDA_HTTP_LOG_REQUESTS" default:"false"`
 }
 
 // Parse parses standard configs using envconfig and returns a pointer to the

interceptor/main.go

@@ -463,8 +463,13 @@ func runProxyServer(
 		rootHandler = otelhttp.NewHandler(rootHandler, "keda-http-interceptor")
 	}
 
+	var requestLogger *logr.Logger
+	if serving.LogRequests {
+		requestLogger = logger
+	}
+
 	rootHandler = middleware.NewLogging(
-		logger,
+		requestLogger,
 		rootHandler,
 	)
 

interceptor/middleware/logging.go

@@ -30,6 +30,10 @@ func NewLogging(logger logr.Logger, upstreamHandler http.Handler) *Logging {
 var _ http.Handler = (*Logging)(nil)
 
 func (lm *Logging) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+	if r.logger == nil {
+		lm.upstreamHandler.ServeHTTP(w, r)
+		return
+	}
 	r = util.RequestWithLogger(r, lm.logger.WithName("LoggingMiddleware"))
 	w = newResponseWriter(w)