Skip to content

Commit b659015

Browse files
author
Jonathan Ginsburg
committed
ci: lint and commitlint in its own workflow
Source of inspiration: karma-runner/karma-jasmine#313
1 parent 31701a2 commit b659015

File tree

2 files changed

+26
-3
lines changed

2 files changed

+26
-3
lines changed

.github/workflows/lint.yml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: Lint
2+
3+
on:
4+
pull_request:
5+
branches:
6+
- master
7+
8+
jobs:
9+
linux:
10+
name: Linux - Lint
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v2
14+
with:
15+
fetch-depth: 0
16+
- uses: actions/setup-node@v2
17+
with:
18+
node-version: 14
19+
cache: npm
20+
- run: npm ci
21+
- run: |
22+
npm run commitlint -- \
23+
--verbose \
24+
--from `git merge-base origin/master $GITHUB_SHA`
25+
- run: npm run lint

.github/workflows/test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77

88
jobs:
99
main:
10-
name: Lint and Unit (Client and Server), E2E and Integration Test
10+
name: Unit (Client and Server), E2E and Integration Test
1111
runs-on: ubuntu-latest
1212
env:
1313
BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
@@ -23,8 +23,6 @@ jobs:
2323
node-version: 14
2424
cache: npm
2525
- run: npm ci
26-
- run: npm run commitlint -- --from `git merge-base origin/master $GITHUB_SHA`
27-
- run: npm run lint
2826
- run: npm run build:check
2927
- run: npm run test:unit
3028
- run: npm run test:e2e

0 commit comments

Comments
 (0)