Use golangci-lint v2 (#1150)

Signed-off-by: apedriza <adripedriza@gmail.com>

Author: apedriza

.github/workflows/lint.yml

@@ -51,6 +51,6 @@ jobs:
 
       - name: Run linter
         env:
-          GOLANGCI_LINT_FLAGS: --out-format=github-actions
+          GOLANGCI_LINT_FLAGS: --output.text.path=stdout
         run: |
           make lint

.golangci.yml

@@ -1,19 +1,57 @@
-# options for analysis running
+version: "2"
 run:
-  timeout: 8m
-
   build-tags:
     - hack
-  skip-dirs-use-default: false
-  skip-files:
-    - "zz_*"
-  tests: true
   modules-download-mode: readonly
+  tests: true
   allow-parallel-runners: true
-
 linters:
+  default: none 
+  enable:
+    - depguard
+    - goheader
+    - revive
+  settings:
+    revive:
+      rules:
+        # The following rules are recommended https://github.com/mgechev/revive#recommended-configuration
+        - name: blank-imports
+        - name: context-as-argument
+        - name: context-keys-type
+        - name: dot-imports
+        - name: error-return
+        - name: error-strings
+        - name: error-naming
+        - name: exported
+        - name: if-return
+        - name: increment-decrement
+        - name: var-naming
+        - name: var-declaration
+        - name: package-comments
+        - name: range
+        - name: receiver-naming
+        - name: time-naming
+        - name: unexported-return
+        - name: indent-error-flow
+        - name: errorf
+        - name: empty-block
+        - name: superfluous-else
+        - name: unused-parameter
+        - name: unreachable-code
+        - name: redefines-builtin-id
+  exclusions:
+    generated: strict
+    paths:
+      # Ignore issues in generated files.
+      - zz_generated.*\.go$
+formatters:
   enable:
-    - depguard     # Checks if package imports are in a list of acceptable packages
-    - gofmt        # Checks whether code was gofmt-ed
-    - goheader     # Checks is file headers matche a given pattern
-    - revive       # Stricter drop-in replacement for golint
+    - gofmt
+  exclusions:
+    generated: strict
+    paths:
+      - zz_generated.*\.go$
+# Warn only about new issues, not existing ones. 
+# TODO: Remove this filter at some point and ensure all old issues are fixed.
+issues:
+  new-from-merge-base: HEAD~

Makefile

@@ -307,7 +307,7 @@ lint: hack/lint/.golangci-lint.stamp
 	  --rm \
 	  -v "$(CURDIR):/go/src/github.com/k0sproject/k0smotron:ro" \
 	  -w /go/src/github.com/k0sproject/k0smotron \
-	  k0smotron.golangci-lint golangci-lint run $(GOLANGCI_LINT_FLAGS) $(GO_LINT_DIRS)
+	  k0smotron.golangci-lint golangci-lint run --config .golangci.yml $(GOLANGCI_LINT_FLAGS) $(GO_LINT_DIRS)
 
 # KinD helpers
 .PHONY: kind-cluster

Makefile.variables

@@ -1,5 +1,5 @@
 KUSTOMIZE_VERSION ?= v5.0.1
 CONTROLLER_TOOLS_VERSION ?= v0.14.0
-GO_VERSION ?= 1.22.6
-GOLANGCILINT_VERSION ?= 1.52.2
+GO_VERSION ?= 1.23.0
+GOLANGCILINT_VERSION ?= 2.3.0
 CRDOC_VERSION ?= v0.6.2

hack/lint/Dockerfile

@@ -3,7 +3,7 @@ ARG BUILD_IMG
 FROM ${BUILD_IMG} AS builder
 ARG GOLANGCILINT_VERSION
 
-RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v${GOLANGCILINT_VERSION}
+RUN go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v${GOLANGCILINT_VERSION}
 
 # Ref https://github.com/golangci/golangci-lint/pull/4034
 RUN git config --global --add safe.directory '*'