Skip to content

Commit d7aa878

Browse files
authored
Merge pull request #1454 from mathbunnyru/asalikhov/fix_r_installation
Build r-notebook under arm (again) and fix datascience-notebook build
2 parents aa73424 + 0f9ab2a commit d7aa878

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ OWNER?=jupyter
1414
MULTI_IMAGES:= \
1515
base-notebook \
1616
minimal-notebook \
17+
r-notebook \
1718
scipy-notebook \
1819
pyspark-notebook \
1920
all-spark-notebook
2021
# Images that can only be built on the amd64 architecture (aka. x86_64)
2122
AMD64_ONLY_IMAGES:= \
22-
r-notebook \
2323
datascience-notebook \
2424
tensorflow-notebook
2525
# All of the images

datascience-notebook/Dockerfile

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,28 @@ RUN mamba install --quiet --yes \
7474
'r-nycflights13' \
7575
'r-randomforest' \
7676
'r-rcurl' \
77-
'r-rmarkdown' \
7877
'r-rodbc' \
7978
'r-rsqlite' \
8079
'r-shiny' \
81-
'r-tidymodels' \
82-
'r-tidyverse' \
8380
'rpy2' \
8481
'unixodbc' && \
8582
mamba clean --all -f -y && \
8683
fix-permissions "${CONDA_DIR}" && \
8784
fix-permissions "/home/${NB_USER}"
8885

86+
# These packages are not easy to install under arm
87+
RUN set -x && \
88+
arch=$(uname -m) && \
89+
if [ "${arch}" == "x86_64" ]; then \
90+
mamba install --quiet --yes \
91+
'r-rmarkdown' \
92+
'r-tidymodels' \
93+
'r-tidyverse' && \
94+
mamba clean --all -f -y && \
95+
fix-permissions "${CONDA_DIR}" && \
96+
fix-permissions "/home/${NB_USER}"; \
97+
fi;
98+
8999
# Add Julia packages.
90100
# Install IJulia as jovyan and then move the kernelspec out
91101
# to the system share location. Avoids problems with runtime UID change not

r-notebook/Dockerfile

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,23 @@ RUN mamba install --quiet --yes \
4040
'r-nycflights13' \
4141
'r-randomforest' \
4242
'r-rcurl' \
43-
'r-rmarkdown' \
4443
'r-rodbc' \
4544
'r-rsqlite' \
4645
'r-shiny' \
47-
'r-tidymodels' \
48-
'r-tidyverse' \
4946
'unixodbc' && \
5047
mamba clean --all -f -y && \
5148
fix-permissions "${CONDA_DIR}" && \
5249
fix-permissions "/home/${NB_USER}"
50+
51+
# These packages are not easy to install under arm
52+
RUN set -x && \
53+
arch=$(uname -m) && \
54+
if [ "${arch}" == "x86_64" ]; then \
55+
mamba install --quiet --yes \
56+
'r-rmarkdown' \
57+
'r-tidymodels' \
58+
'r-tidyverse' && \
59+
mamba clean --all -f -y && \
60+
fix-permissions "${CONDA_DIR}" && \
61+
fix-permissions "/home/${NB_USER}"; \
62+
fi;

0 commit comments

Comments
 (0)