Skip to content

Fix for issue #81 - sourceMappingUrl is wrong.#123

Merged
jhnns merged 1 commit intowebpack:masterfrom
lewie9021:master
Jul 23, 2015
Merged

Fix for issue #81 - sourceMappingUrl is wrong.#123
jhnns merged 1 commit intowebpack:masterfrom
lewie9021:master

Conversation

@lewie9021
Copy link
Contributor

Small change discussed in issue #81. Making the change indeed fixes source mapping so I thought I'd create this pull request.

@jorrit
Copy link
Contributor

jorrit commented Jul 20, 2015

Maybe you can add a comment to the line to explain why it is necessary, for future reference.

@jhnns
Copy link
Member

jhnns commented Jul 23, 2015

I see, we need to omit the source maps because otherwise webpack's source map comment would be ignored. Without .omitSourceMapUrl it looks like this:

body {
  background: lightgrey; }

/*# sourceMappingURL=test/output/sass.map */  <-- from node-sass
/*# sourceMappingURL=data:application/json;base64,...*/  <-- from webpack

jhnns added a commit that referenced this pull request Jul 23, 2015
Fix for issue #81 - sourceMappingUrl is wrong.
@jhnns jhnns merged commit 2d81a95 into webpack:master Jul 23, 2015
@jhnns
Copy link
Member

jhnns commented Jul 23, 2015

Will be published soon. I just need to do some tests and I'll update the docs. Also related to #104.

@jhnns jhnns mentioned this pull request Jul 23, 2015
@jhnns
Copy link
Member

jhnns commented Aug 3, 2015

Shipped with 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants