Ensure the URL API roundtrips for opaque paths

Follows whatwg/url#728.

Author: domenic

README.md

@@ -4,7 +4,7 @@ whatwg-url is a full implementation of the WHATWG [URL Standard](https://url.spe
 
 ## Specification conformance
 
-whatwg-url is currently up to date with the URL spec up to commit [48f1e79](https://github.com/whatwg/url/commit/48f1e79e5d930bf95eaffbbe6c7ae5ed81d397a0).
+whatwg-url is currently up to date with the URL spec up to commit [fdaa0e5](https://github.com/whatwg/url/commit/fdaa0e5a3790693a82f578d7373f216d8fef9ac8).
 
 For `file:` URLs, whose [origin is left unspecified](https://url.spec.whatwg.org/#concept-url-origin), whatwg-url chooses to use a new opaque origin (which serializes to `"null"`).
 

lib/URL-impl.js

@@ -171,6 +171,7 @@ exports.implementation = class URLImpl {
     if (v === "") {
       url.query = null;
       this._query._list = [];
+      this._potentiallyStripTrailingSpacesFromAnOpaquePath();
       return;
     }
 
@@ -195,6 +196,7 @@ exports.implementation = class URLImpl {
   set hash(v) {
     if (v === "") {
       this._url.fragment = null;
+      this._potentiallyStripTrailingSpacesFromAnOpaquePath();
       return;
     }
 
@@ -206,4 +208,20 @@ exports.implementation = class URLImpl {
   toJSON() {
     return this.href;
   }
+
+  _potentiallyStripTrailingSpacesFromAnOpaquePath() {
+    if (!usm.hasAnOpaquePath(this._url)) {
+      return;
+    }
+
+    if (this._url.fragment !== null) {
+      return;
+    }
+
+    if (this._url.query !== null) {
+      return;
+    }
+
+    this._url.path = this._url.path.replace(/\u0020+$/u, "");
+  }
 };

lib/URLSearchParams-impl.js

@@ -31,11 +31,16 @@ exports.implementation = class URLSearchParamsImpl {
 
   _updateSteps() {
     if (this._url !== null) {
-      let query = urlencoded.serializeUrlencoded(this._list);
-      if (query === "") {
-        query = null;
+      let serializedQuery = urlencoded.serializeUrlencoded(this._list);
+      if (serializedQuery === "") {
+        serializedQuery = null;
+      }
+
+      this._url._url.query = serializedQuery;
+
+      if (serializedQuery === null) {
+        this._url._potentiallyStripTrailingSpacesFromAnOpaquePath();
       }
-      this._url._url.query = query;
     }
   }
 

scripts/get-latest-platform-tests.js

@@ -18,7 +18,7 @@ process.on("unhandledRejection", err => {
 // 1. Go to https://github.com/web-platform-tests/wpt/tree/master/url
 // 2. Press "y" on your keyboard to get a permalink
 // 3. Copy the commit hash
-const commitHash = "0a187bc16933e67dfb8755935143a6dd5a9e12f2";
+const commitHash = "d9d78543960a04ea8ad8f1aa3c7536b6a9a87d9a";
 
 const urlPrefix = `https://raw.githubusercontent.com/web-platform-tests/wpt/${commitHash}/url/`;
 const targetDir = path.resolve(__dirname, "..", "test", "web-platform-tests");